chore: update @oclif/core to v4 and migrate ESLint to v9 flat config#392
Open
chore: update @oclif/core to v4 and migrate ESLint to v9 flat config#392
Conversation
- Upgrade @oclif/core from ^2.8.12 to ^4.0.0 (fixes #391) - Replace removed ux.table with custom src/ux-table.js (ESM-only @oclif/table is incompatible with CJS) - Upgrade @adobe/eslint-config-aio-lib-config to 5.0.0, eslint to ^9.0.0 - Migrate ESLint config from .eslintrc to eslint.config.js (flat config format) - Patch Command.prototype.parse in test setup for oclif v4 config.runHook requirement - Update createTestFlagsFunction to check 'flags' instead of '_flags' (oclif v4 change) - Simplify api/list.js --json flag handling (remove oclif v2 workaround) - Maintain 100% branch/line/statement coverage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shazron
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #391
Summary
@oclif/corefrom^2.8.12to^4.0.0, resolving chore: update @oclif/core to latest version #391ux.tablewith a customsrc/ux-table.jscompatible with the CJS project (the official@oclif/tablereplacement is ESM-only)@adobe/eslint-config-aio-lib-configto5.0.0andeslintto^9.0.0.eslintrctoeslint.config.js(flat config format required by ESLint v9)oclifCLI to^4.0.0andeslint-plugin-jestto^29.0.0Breaking changes handled
ux.tableremoved in v4 → custom table implementation preserving identical output formatCommand.parse()now requiresthis.config.runHook→ patched in test setup for unit tests that instantiate commands directly_flagsinternal property removed → updatedcreateTestFlagsFunctionto checkflagsinsteadargvis now a writable class field → simplified test that previously used a getter-onlyObject.definePropertyTest plan
npm test)npm run lint)🤖 Generated with Claude Code