Skip to content

feat: remove unneeded npm overrides to unblock npm publish#832

Merged
dthampy merged 1 commit into
masterfrom
remove-npm-overrides
Jun 3, 2026
Merged

feat: remove unneeded npm overrides to unblock npm publish#832
dthampy merged 1 commit into
masterfrom
remove-npm-overrides

Conversation

@dthampy
Copy link
Copy Markdown
Contributor

@dthampy dthampy commented Jun 3, 2026

Description

  • newly added check-overrides.js script is now gating the publish and checks for any npm overrides in the package.json. So those two stale override entries need be removed before it can be released

Related Issue

Motivation and Context

How Has This Been Tested?

  • Ran. npm run check-overrides
    • Removed those two stale entries from package.json
  • Re ran npm install
  • re ran npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 PR Reviewer

This diff contains only documentation updates (README.md flag syntax corrections adding =<value> to flags that accept values), dependency lock file changes, and minor package.json override removals. The changes are mechanical and correct — the README now accurately reflects that flags like --cert, --key, --apihost, --apiversion, and --auth require values. The lock file and package.json changes remove unnecessary overrides and adjust dependency resolution. No code logic is changed.

LGTM! This PR looks good to merge.


💡 How to re-trigger

Comment /review or /pr-reviewer on this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dthampy dthampy merged commit 4786faf into master Jun 3, 2026
11 checks passed
@dthampy dthampy deleted the remove-npm-overrides branch June 3, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants