Skip to content

feat: add get project install config endpoint#81

Merged
MichaelGoberling merged 2 commits intomasterfrom
feature/ACNA-2837-fetch-install-config
Apr 2, 2024
Merged

feat: add get project install config endpoint#81
MichaelGoberling merged 2 commits intomasterfrom
feature/ACNA-2837-fetch-install-config

Conversation

@MichaelGoberling
Copy link
Copy Markdown
Contributor

Description

Add the new endpoint for fetching a project's install config

See Transporter API docs: https://developers.corp.adobe.com/adobeio/transporter/transporterSwagger.json#tag/Data/paths/~1console~1data~1projects~1{projectId}~1install-config/get

Related Issue

Motivation and Context

Allow template registry service to copy the install config for a given project

How Has This Been Tested?

Locally linked package, npm run test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2794a50) to head (87a5b4e).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          505       513    +8     
  Branches        15        15           
=========================================
+ Hits           505       513    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@arjuncooliitr arjuncooliitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@shazron
Copy link
Copy Markdown
Member

shazron commented Mar 27, 2024

Was this just a drop-in from their OpenAPI spec file or you had to copy and paste this in?

@MichaelGoberling
Copy link
Copy Markdown
Contributor Author

MichaelGoberling commented Mar 27, 2024

@shazron

This was a copy and paste, I originally did a full copy but there were a lot more changes than I expected, including some changes to existing paths (may have been breaking changes?). Should we create a follow-up task to sync with the latest?

@shazron
Copy link
Copy Markdown
Member

shazron commented Mar 28, 2024

@MichaelGoberling we've been doing patches for one-off additions: https://github.com/adobe/aio-lib-console/tree/master/spec/patch - this is so we can just drop-in any new Transporter specs. But now that you mentioned that there are other breaking changes, not sure

@MichaelGoberling
Copy link
Copy Markdown
Contributor Author

MichaelGoberling commented Mar 28, 2024

@shazron

Ah, I see. I think the patch is needed for that one xr endpoint because it isn't in the Swagger definition. The endpoint I added as part of this PR is part of the Swagger, I just decided to forgo doing the full drop-in because it included more changes than I expected. Let me try to do the full drop-in and do some testing on this PR

Edit: Okay, just pushed a change doing the full drop-in. I updated any endpoints we currently support in index.js and left any new endpoints alone. The endpoints that had path changes were not in index.js, so I think we're good there

@MichaelGoberling MichaelGoberling merged commit 8c452fe into master Apr 2, 2024
@MichaelGoberling MichaelGoberling deleted the feature/ACNA-2837-fetch-install-config branch April 2, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants