GH-127 moving the integration test with re-usable testers in a new aio-lib-java-events-test module#128
Merged
francoisledroff merged 6 commits intomainfrom Nov 3, 2022
Merged
GH-127 moving the integration test with re-usable testers in a new aio-lib-java-events-test module#128francoisledroff merged 6 commits intomainfrom
testers in a new aio-lib-java-events-test module#128francoisledroff merged 6 commits intomainfrom
Conversation
…`aio-lib-java-events-test` module
| } | ||
|
|
||
|
|
||
| public void deleteProvider(String providerId) { |
Collaborator
There was a problem hiding this comment.
many times i have seen that when an assertion fails, the test stops and the provider that is created is not cleaned up. Then we end up with a lot of test providers in that org. Can we ensure that the cleanup happens even if the test fails?
Collaborator
There was a problem hiding this comment.
same for other tests
Collaborator
Author
There was a problem hiding this comment.
thanks. done
+ small code polish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moving the integration test with re-usable
testersin a newaio-lib-java-events-testmodulesee see #127