Add support for Registration V2 API #132
Merged
francoisledroff merged 12 commits intomainfrom Nov 29, 2022
Merged
Conversation
Add support for Registration V2 API
francoisledroff
requested changes
Nov 23, 2022
Collaborator
francoisledroff
left a comment
francoisledroff
left a comment
There was a problem hiding this comment.
here is my first quick review
| .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false) | ||
| .serializationInclusion(Include.NON_NULL) | ||
| .addModule(new SimpleModule() | ||
| .addSerializer(ZonedDateTime.class, new ZonedDateTimeSerializer()) |
Collaborator
Author
There was a problem hiding this comment.
need to check.
events_mgmt/src/main/java/com/adobe/aio/event/management/model/RegistrationUpdateModel.java
Outdated
Show resolved
Hide resolved
events_mgmt/src/main/java/com/adobe/aio/event/management/model/RegistrationCreateModel.java
Outdated
Show resolved
Hide resolved
events_mgmt/src/main/java/com/adobe/aio/event/management/model/Registration.java
Outdated
Show resolved
Hide resolved
events_mgmt/src/main/java/com/adobe/aio/event/management/model/EventsOfInterestInputModel.java
Outdated
Show resolved
Hide resolved
fix: address review comments
francoisledroff
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add RegistrationCreateModel, RegistrationUpdateModel, EventsOfInterestInputModel
Update Registration model to include HAL links and other changes wrt the new registration API response
Update Jackson Object Mapper to support HAL JSON
Update the integration and unit tests
Other fixes to support these changes
Related Issue
events_mgmt: Align with the latest/V2Adobe I/O Events Registration API #131Motivation and Context
Adds support for the latest Registration IO Management API. For more details see: https://developer.adobe.com/events/docs/api/#tag/Registrations
How Has This Been Tested?
Integration tests and unit tests
Screenshots (if appropriate):
Types of changes
Checklist: