Skip to content

GH-157: add pollJournalForEvents to check for a set of eventIds to be in the journal#158

Merged
nicdard merged 1 commit intomainfrom
journal-polling
May 31, 2023
Merged

GH-157: add pollJournalForEvents to check for a set of eventIds to be in the journal#158
nicdard merged 1 commit intomainfrom
journal-polling

Conversation

@nicdard
Copy link
Copy Markdown
Collaborator

@nicdard nicdard commented May 30, 2023

Description

add a JournalServiceTester#pollJournalForEvents method to poll the journal for the given set of eventIds.
Related Issue

Related Issue

#157

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nicdard nicdard temporarily deployed to aio_stage May 30, 2023 17:27 — with GitHub Actions Inactive
@nicdard nicdard temporarily deployed to aio_prod May 30, 2023 17:27 — with GitHub Actions Inactive
@nicdard nicdard changed the title feat: add pollJournalForEvents to check for a set of eventIds to be in the journal GH-157: add pollJournalForEvents to check for a set of eventIds to be in the journal May 30, 2023
Copy link
Copy Markdown
Collaborator

@francoisledroff francoisledroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicdard nicdard merged commit 2deb2ad into main May 31, 2023
@nicdard nicdard deleted the journal-polling branch May 31, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants