Skip to content

Enhancements to read adobe_mc from malformed URIs#1489

Merged
carterworks merged 2 commits into
mainfrom
fix/adobemcQueryParams
May 1, 2026
Merged

Enhancements to read adobe_mc from malformed URIs#1489
carterworks merged 2 commits into
mainfrom
fix/adobemcQueryParams

Conversation

@Spencer-Smith
Copy link
Copy Markdown
Collaborator

Changed Packages

  • core
  • reactor-extension

Description

Implemented two "enhancements" for reading identity (adobe_mc) from URI query parameters:

  1. Attempts to read when query parameter in location.hash (only when parameter does not exist in location.search)
  2. Attempts to read when the value is "over-encoded" (been encoded more than once)

Related Issue

Jira 1
Jira 2

Motivation and Context

Issue 1 seems to be an issue for some SPA implemented in React,

Screenshots (if appropriate):

N/A

Documentation

No. Arguably this fixes a regression (at least for issue 1) because this "used to work" with a previous feature.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have added a Changeset file with a consumer-facing description of my changes.
  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 29, 2026

🦋 Changeset detected

Latest commit: 305cbe2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@adobe/alloy-core Patch
@adobe/alloy-sandbox-browser Patch
@adobe/alloy Patch
@adobe/alloy-node Patch
reactor-extension-alloy Patch
@adobe/alloy-sandbox-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@carterworks carterworks merged commit 259138e into main May 1, 2026
12 of 13 checks passed
@carterworks carterworks deleted the fix/adobemcQueryParams branch May 1, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants