Support for target VEC click tracking metrics#491
Merged
Conversation
ninaceban
changed the title
jfkhoury
approved these changes
May 7, 2020
Contributor
jfkhoury
left a comment
jfkhoury
left a comment
There was a problem hiding this comment.
Thank you! My only comment would be: do we need to make the event names more descriptive? Like “display-autorendered-offer” or something, same for click.. I’ll leave it to you and David.
Aaronius
approved these changes
May 7, 2020
Contributor
Aaronius
left a comment
Aaronius
left a comment
There was a problem hiding this comment.
I had the same thoughts as @jfkhoury. Thanks @ninaceban.
jonsnyder
requested changes
May 7, 2020
Contributor
Author
ninaceban
force-pushed
the
personalization-clicktracking
branch
from
df12693 to
0461dbc
Compare
jonsnyder
approved these changes
May 8, 2020
Spencer-Smith
pushed a commit
that referenced
this pull request
Feb 20, 2026
… error (#491) * Ensure the library is built before starting dev sandbox * Permit empty string as a valid-to-be-ignored idSyncContainerId override value * Add unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added click tracking support for target VEC click tracking metrics.
I have added an event
type:displayfor visual experiencesclickfor click tracking metricsRelated Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: