This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Added implementation for realpath in GetFileInfo#425
Closed
Queuecumber wants to merge 1 commit into
Closed
Conversation
Expands symbolic links in GetFileInfo for gtk/linux hosts using posix realpath function
Author
|
Quick question: are you guys enforcing any standard that directory paths should always with a '/' ? If so I'll close this and update my code to return a realpath for directories that always ends in '/' and submit it under a new PR. |
Contributor
|
Hi @Queuecumber, we are currently preparing our Sprint 37 release and didn't have that much time to look at the PR. We will take care of it in the next couple of days. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands symbolic links in GetFileInfo for gtk/linux hosts using posix realpath function
Required for brackets-git plugin to work properly in linux environments that use symlinks and completes GetFileInfo on these platforms. Probably makes sense to add this to the mac implementation as well but the windows implementation would get nothing from it.