Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

[REVIEW ONLY] Do not merge -- Release 39 update Notification#131

Closed
JeffryBooher wants to merge 3 commits intomasterfrom
jeff/Sprint39b
Closed

[REVIEW ONLY] Do not merge -- Release 39 update Notification#131
JeffryBooher wants to merge 3 commits intomasterfrom
jeff/Sprint39b

Conversation

@JeffryBooher
Copy link
Copy Markdown
Contributor

Release 39 Update Notification

@JeffryBooher
Copy link
Copy Markdown
Contributor Author

@njx @peterflynn

Comment thread updates/stable/en.json Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: should be Croatian

@TomMalbran
Copy link
Copy Markdown
Contributor

BTW, shouldn't this be merged into https://github.com/adobe/brackets.io? Since we are getting the updates from there now?

@JeffryBooher
Copy link
Copy Markdown
Contributor Author

@TomMalbran that's an interesting point. I will bring it up tomorrow at the standup. I'm not sure if we're all the way there yet with the notifications.

@TomMalbran
Copy link
Copy Markdown
Contributor

@JeffryBooher The config.json file is already pointing to brackets.io:
https://github.com/adobe/brackets/blob/release/src/config.json#L6

@JeffryBooher JeffryBooher deleted the jeff/Sprint39b branch May 12, 2014 04:33
@marcelgerber
Copy link
Copy Markdown
Contributor

Well, I guess it's supposed to be on both http://brackets.io and http://dev.brackets.io so that the old Sprints (like 38) will still get a notification.
Or we could just setup a redirect in the .htaccess of this branch. That's probably the easiest.

Comment thread updates/stable/de.json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, it's probably easier if you only update en.json first, then wait for all of the review changes to be integrated until making copies for the other languages.

@TomMalbran
Copy link
Copy Markdown
Contributor

@SAplayer Right I haven't thought about that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants