live development from user-specified base url does not work

[joelrbrandt]

Live development no longer works with a user-specified base url.

83190c9 brought code into LiveDevelopment.js that calls _serverProvider.setRequestFilterPaths on any server provider. However, when the user specifies a base url, a different server provider is used (UserServerProvider, defined in LiveDevelopment.js). This provider does not have the necessary interface.

Based on a really quick read of the code, it seems to me that setRequestFilterPaths code should be specific to the StaticServerProvider. So, I'm exactly sure why this code is in LiveDevelopment.js. But I could easily be misunderstanding something.

Even if I add a no-op setRequestFilterPaths function to UserServerProvider, live development still doesn't work correctly. It never fully connects, and every time I switch files, a new tab is opened in Chrome.

cc @gruehle since it looks like he added the setRequestFilterPaths call to LiveDevelopment.js

[gruehle]

@jasonsanjose can you take a look? I'm sitting on a beach and don't have access to a computer this week. Thanks!

[peterflynn]

Tagging Sprint 23 & assigning so it doesn't slip off the radar

[njx]

Also, we should figure out why there was no unit test failure for this.

[redmunds]

FBNC back to @joelrbrandt.

[redmunds]

@RaymondLim This is probably why you could not get server-side smokes working for PHP file.

[joelrbrandt]

@jasonsanjose This doesn't seem to be fixed for me. I'm on mac using the shell from the Sprint 22 build, and I'm at 3551e40 in Brackets.

Here's what I did to repro (and the results):

1. Set up a local server to serve the contents of the "citrus completed" folder at http://localhost:8080/
2. Opened the "citrus completed" folder in Brackets, and set the Live Development base url to http://localhost:8080/
3. Closed Chrome
4. Clicked the live dev button
5. The correct url (http://localhost:8080/) did indeed open in my browser. However, the live dev connection never fully completed. The lightning bolt stayed half-colored for awhile, then went to grey
6. When I switch to a CSS file, the lightning bolt turns fully solid yellow. However, it doesn't seem to actually be connected (changes do not affect the browser)

Let me know if you need any more info to repro.

[joelrbrandt]

Also, I'm not sure how this bug got closed. I think maybe because the commit message said "Fix" and then the issue number?

[redmunds]

@joelrbrandt I think the bug got auto-closed. I just merged this fix an hour ago, so be sure to pull the latest from master.