Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

[CEF 2623] Upgrade to latest CEF#12415

Merged
swmitra merged 4 commits into
masterfrom
prashant/cef-upgrade-latest
May 13, 2016
Merged

[CEF 2623] Upgrade to latest CEF#12415
swmitra merged 4 commits into
masterfrom
prashant/cef-upgrade-latest

Conversation

@nethip
Copy link
Copy Markdown
Contributor

@nethip nethip commented May 11, 2016

With latest CEF, quick open is not showing the results as opacity was set to 0. So removed opacity for .quick-search-container

This is required for updating shell APIt
Related PR :adobe/brackets-shell#544

… set to 0. So removed opacity for .quick-search-container
@nethip
Copy link
Copy Markdown
Contributor Author

nethip commented May 11, 2016

@swmitra Could you have a look at this PR?

@nethip
Copy link
Copy Markdown
Contributor Author

nethip commented May 11, 2016

@marcelgerber @ingorichter @peterflynn Would you guys be able to review this PR?

@Denisov21
Copy link
Copy Markdown
Contributor

👍 Good for me!

@marcelgerber marcelgerber force-pushed the prashant/cef-upgrade-latest branch from 85c231d to c66f729 Compare May 12, 2016 16:39
@marcelgerber
Copy link
Copy Markdown
Contributor

@nethip I have altered this PR by actually fixing the .animation LESS mixin (which was the reason why Quick Open failed), fixing it in other locations, too, and adding opacity: 0 back.

@nethip
Copy link
Copy Markdown
Contributor Author

nethip commented May 12, 2016

@marcelgerber thanks for fixing the actual problem.

@swmitra
Copy link
Copy Markdown
Collaborator

swmitra commented May 13, 2016

LGTM.
Kudos to @nethip 👍 for this PR and the related PR in brackets-shell.
Great job by @marcelgerber by providing quick fix for the quick open issue 👍
Merging...

@swmitra swmitra merged commit ff4707f into master May 13, 2016
@swmitra swmitra deleted the prashant/cef-upgrade-latest branch May 13, 2016 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants