This repository was archived by the owner on Sep 6, 2021. It is now read-only.
In case unsaved file, Tern is returning filename without forward slash#14055
Merged
boopeshmahendran merged 2 commits intomasterfrom Jan 20, 2018
Merged
In case unsaved file, Tern is returning filename without forward slash#14055boopeshmahendran merged 2 commits intomasterfrom
boopeshmahendran merged 2 commits intomasterfrom
Conversation
swmitra
approved these changes
Jan 20, 2018
| function isInSameFile(obj, refsResp) { | ||
| return (obj && obj.file === refsResp.file); | ||
| // In case of unsaved files, After renameing once Tern is returning filename without forward slash | ||
| return (obj && (obj.file === refsResp.file || (obj.file === refsResp.file.slice(1, refsResp.file.length)))); |
Collaborator
There was a problem hiding this comment.
Can be written as -
return (obj && (obj.file === refsResp.file || obj.file === refsResp.file.slice(1, refsResp.file.length)));
By eliminating the last brace.
boopeshmahendran
approved these changes
Jan 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #14053
Please review @swmitra @nethip @boopeshmahendran