Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Larz/linux scrollbar #5082

Closed
larz0 wants to merge 7 commits into from
Closed

Larz/linux scrollbar #5082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
48b8833
Added styling for scrollbars.
larz0 Aug 23, 2013
0db317b
Tweaked styling.
larz0 Aug 24, 2013
4ddb730
Merge branch 'master' of https://github.com/adobe/brackets into larz/…
larz0 Sep 5, 2013
b3c4105
Updated style.
larz0 Sep 5, 2013
5e4a982
Added transparent white border for dark themes.
larz0 Sep 5, 2013
59a2d0f
Merge branch 'master' of https://github.com/adobe/brackets into larz/…
larz0 Sep 5, 2013
f8192c7
Custom scrollbar is now linux-only.
larz0 Sep 5, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extensions/default/JavaScriptCodeHints/thirdparty/acorn
Open in desktop
Submodule acorn updated from c152be to a84e21
2 changes: 1 addition & 1 deletion src/extensions/default/JavaScriptCodeHints/thirdparty/tern
Open in desktop
Submodule tern updated from 21c9f9 to fb2bb8
23 changes: 22 additions & 1 deletion src/styles/brackets.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,29 @@ html, body {
backface-visibility: hidden;
}

body {
.platform-linux {
height: 100%;
Copy link
Copy Markdown
Contributor

@TomMalbran TomMalbran Sep 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be applied to all the platforms?

Copy link
Copy Markdown
Member Author

@larz0 larz0 Sep 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it shouldn't. It already looks like that on Mac and @jasonsanjose is working on the Windows scrollbar that'll look more like the scrollbar on Windows 8.

Copy link
Copy Markdown
Contributor

@TomMalbran TomMalbran Sep 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean just the height: 100% property which was applied to the body, and therefor all the platforms, before this change.

And yay on the coming windows custom scrollbars.

Copy link
Copy Markdown
Member Author

@larz0 larz0 Sep 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yes. I need to change that.

Copy link
Copy Markdown
Member

@jasonsanjose jasonsanjose Sep 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #5083

::-webkit-scrollbar {
width: 8px;
height: 8px;
}

::-webkit-scrollbar-track-piece {
background: none;
}

::-webkit-scrollbar-thumb {
background: @custom-scrollbar-thumb;
border-radius: 4px;
}

::-webkit-scrollbar-corner {
background: none;
}

::-webkit-scrollbar-thumb:window-inactive {
background: @custom-scrollbar-thumb-inactive;
}
}

.resizing-container {
Expand Down
6 changes: 5 additions & 1 deletion src/styles/brackets_theme_default.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,17 @@
@open-working-file-name-highlight: #8fddff;
@open-working-file-ext-highlight: #8fddff;

/* Selection colors */
/* selection colors */
@selection-color-focused: #D9EFF7;
@selection-color-unfocused: #e9e9e9;

/* background color of the line that has the cursor */
@activeline-bgcolor: #e6e9e9;

/* custom scrollbar colors */
@custom-scrollbar-thumb: rgba(0, 0, 0, 0.24);
@custom-scrollbar-thumb-inactive: rgba(0, 0, 0, 0.12);

/* Code font formatting
*
* NOTE (JRB): In order to get the web font to load early enough, we have a div called "dummy-text" that
Expand Down
2 changes: 1 addition & 1 deletion src/thirdparty/CodeMirror2
Open in desktop
Submodule CodeMirror2 updated from 2d51b3 to a71f5f