Add missing param

[redmunds]

This is for #6718

cc @njx

[njx]

I'm not sure this is right. I think the Boolean(rev) is intended to be the first argument to getCursorPos() (the second argument is new and optional). But I'm actually not sure why it would pass true in the original code for Find Previous, since I would assume we always want to use the real cursor position, not the one that expands tabs.

[njx]

It does seem to fix it, though...but I don't understand why. Looking...

[njx]

(Edited for clarity...)

Oh, I see. It was the "which end of the selection" argument to the original CodeMirror getCursor(), but we changed this to Editor.getCursorPos(), which takes that as the second argument.

Two things to change though:

• CM doesn't document using true/false for that arg, and we don't either, so we should pass "start" and "end" instead (i.e., rev ? "start" : "end").
• The first argument you added should be false, not true (we want it without tab expansion, I think - true should only be used for displaying the column number to the user; internally tabs should just be considered one character when dealing with CM positions).

[njx]

Just edited my previous comment to clarify it (hopefully)...

[redmunds]

Changes pushed. I realized that the expand tabs arg was wrong while I was at lunch. I originally had that change for the other param, but figured I'd minimize the change -- I like it more explicit like this.

[njx]

Looks good. Can't tell if it breaks any unit tests since there are a bunch that were already broken :), but seems fine.

[njx]

Oops, I forgot that we wanted to use "from" and "to" instead of "start" and "end" here (both work, but "from" and "to" are the official ones listed in the CM docs). I'll fix that later.

[njx]

Ignore that last comment, we're keeping "start" and "end".