This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Skip all embedded php code when parsing the style blocks in php documents.#7046
Merged
Skip all embedded php code when parsing the style blocks in php documents.#7046
Conversation
Contributor
There was a problem hiding this comment.
I think this may be too hard-coded of a solution. Other devs will want to do something similar for other server-side markup. Also, the mode for php could eventally change to something more specific.
A more generic solution may be this:
- Once you hit
tokenModeName === modeNamecase, scan until you return totokenModeName === outerMode - I am not sure if using
outerModewill work in all cases, you might need to keep track ofpreviousMode(the mode of token before you entermodeNamemode), and then scan until you return topreviousModemode.
What do you think of either of those solutions?
Contributor
Author
There was a problem hiding this comment.
previousMode tracking may be more reliable if we can safely assume that we always have well-formed style blocks. Anyway, I'll make a change with that assumption until someone can prove that to be wrong.
…f we're back to previous mode.
Contributor
Author
|
@redmunds Ready for re-review. |
Contributor
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 24, 2014
Skip all embedded php code when parsing the style blocks in php documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6948.