This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Increase matchBrackets length#7048
Merged
RaymondLim merged 4 commits intomasterfrom Apr 17, 2014
Merged
Conversation
Contributor
Author
|
@RaymondLim I fixed this PR, so it's ready for review. |
Contributor
Author
|
@RaymondLim I'm wondering why such a small pull request hasn't been reviewed yet -- are you concerned about performance? If so, I can change these hard-coded values to be preferences. Let me know. Thanks. |
Contributor
|
@redmunds Sorry for not looking into it sooner for this small change. Looks good. Merging now. |
RaymondLim
added a commit
that referenced
this pull request
Apr 17, 2014
Increase matchBrackets length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #6023
Increased max number of lines from 100 to 1000 and max number of chars from 10,000 to 50,000 with no noticeable difference in performance. This seems like a reasonable increase for now, and we can revise either up or down based on community feedback. I suppose we could even make this a Brackets preference.