Add CSS Shapes Editor extension to Brackets by oslego · Pull Request #7384 · adobe/brackets

oslego · 2014-04-02T18:23:11Z

@RaymondLim, @redmunds, @njx please review / track.

RaymondLim · 2014-04-02T21:39:50Z

Shouldn't it be "set to true to avoid ..."?

larz0 · 2014-04-02T23:38:22Z

@oslego could you use #00a2ff for the blue? I used the wrong blue in the PSD I gave you. Sorry about that!

RaymondLim · 2014-04-03T04:49:50Z

typo: attepts

Conflicts: src/extensions/default/CSSShapesEditor/LiveEditorLocalDriver.js src/extensions/default/CSSShapesEditor/Model.js src/extensions/default/CSSShapesEditor/main.js src/extensions/default/CSSShapesEditor/thirdparty/CSSShapesEditor.js

RaymondLim · 2014-04-03T19:05:09Z

@oslego Can you either remove or comment out all the console.log in your files?

oslego · 2014-04-03T19:26:30Z

@RaymondLim will do. Had them in as a means to know that the injected editor was getting the right commands.

RaymondLim · 2014-04-04T04:54:06Z

You mean Mitigates, right?

TomMalbran · 2014-04-04T16:56:54Z

If these are public methods, the functions shouldn't have a dangling underscore.

…erisks. Asterisks everywhere!

RaymondLim · 2014-04-04T20:13:10Z

This should be {$.Promise=}.

RaymondLim · 2014-04-04T20:29:45Z

Should we remove "clip-path" in this array to match the one used in main.js?

The one in main.js acts like a guard. I think we should keep this intact here, so that when the time does come to support unprefixed clip-path, just the guard needs adjusting. I believe that will avoid confusion.

RaymondLim · 2014-04-04T20:41:57Z

Done with final review. Just have some minor nits. I'll be merging soon even if you can't make these changes.

… false negatives due to CM

oslego · 2014-04-04T20:50:08Z

updated col in negative match test; props used to have prefixes and col 27 was within the property.
remove 2 negative match tests: these are treated by the standalone editor. It will throw error / infer new shape from the element.

These negative tests will pass because CodeMirror doesn't match properties with values. fake-polygon() is perfectly fine for CM. The shapes editor treats this case.

These tests used to pass because of other reasons (e.g.: prefixes)

RaymondLim · 2014-04-04T20:55:21Z

This is a duplicate of the one above.

oslego · 2014-04-04T21:30:13Z

@larz0 Colors changed with RGBA correspondent. Hope you noticed. It's been a stream of changes.

TomMalbran · 2014-04-04T21:30:17Z

same here, since you need to return the promise object

Isn't deferred.reject() returning a failed promise already?

Promise is the same as a Deferred object but without the methods that allow you to change the state. I am saying it because the API says that it returns a Promise and not a Deferred.

RaymondLim · 2014-04-04T21:50:42Z

Merging now for others to do scenario testing. We'll fix some outstanding nits later.

Add CSS Shapes Editor extension to Brackets

marcelgerber · 2014-04-04T22:25:53Z

Nonexistent URL

Not public yet. The full source will surface soon.

larz0 · 2014-04-04T23:26:14Z

Thanks @oslego! 👍

provide CSS Shapes Editor extension as default in Brackets

11c684d

RaymondLim self-assigned this Apr 2, 2014

RaymondLim reviewed Apr 2, 2014
View reviewed changes

RaymondLim reviewed Apr 3, 2014
View reviewed changes

Comment thread src/extensions/default/CSSShapesEditor/LiveEditorLocalDriver.js Outdated

Copy link
Copy Markdown

Contributor

RaymondLim Apr 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: attepts

oslego added 5 commits April 3, 2014 18:06

provide CSS Shapes Editor extension as default in Brackets

41a4d0f

sync with shapes editor lib v0.5.1

a017126

integrate changes from review; fix typos

729fec1

attempt to reconnect editor if page was refreshed

e84e8ea

Merge branch 'master' of github.com:adobe/brackets

a910f25

zhorvath mentioned this pull request Apr 3, 2014

Uncaught TypeError: Cannot call method '_updateStyleActiveLine' of undefined #7399

Closed

Merge branch 'safekeeping' into shapes-editor

58f34be

Conflicts: src/extensions/default/CSSShapesEditor/LiveEditorLocalDriver.js src/extensions/default/CSSShapesEditor/Model.js src/extensions/default/CSSShapesEditor/main.js src/extensions/default/CSSShapesEditor/thirdparty/CSSShapesEditor.js

RaymondLim reviewed Apr 4, 2014
View reviewed changes

oslego added 4 commits April 4, 2014 13:50

Merge branch 'master' of github.com:adobe/brackets

43cbb9a

Merge branch 'master' into shapes-editor

e81af95

Integrate feedback from review: remove typos, fix quotes

1a121f6

sync with shapes editor lib v0.5.2

06b7108

TomMalbran reviewed Apr 4, 2014
View reviewed changes

oslego added 4 commits April 4, 2014 19:09

sync with shapes editor lib v0.5.3

0e53352

Integreate review feedback. Drop underscore from exposed methods. Ast…

18d0269

…erisks. Asterisks everywhere!

Merge branch 'master' of github.com:adobe/brackets

b10f4e6

Merge branch 'master' into shapes-editor

2d955f5

RaymondLim reviewed Apr 4, 2014
View reviewed changes

fix typos; add better comment on SUPPORTED_PROPERTIES

05067f7

RaymondLim reviewed Apr 4, 2014
View reviewed changes

update col in negative match; remove negative match tests - these are…

57efa99

… false negatives due to CM

RaymondLim reviewed Apr 4, 2014
View reviewed changes

Comment thread src/extensions/default/CSSShapesEditor/unittests.js

Copy link
Copy Markdown

Contributor

RaymondLim Apr 4, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the one above.

TomMalbran reviewed Apr 4, 2014
View reviewed changes

RaymondLim added a commit that referenced this pull request Apr 4, 2014

Merge pull request #7384 from oslego/shapes-editor

1a950d0

Add CSS Shapes Editor extension to Brackets

RaymondLim merged commit 1a950d0 into adobe:master Apr 4, 2014

marcelgerber reviewed Apr 4, 2014
View reviewed changes

RaymondLim mentioned this pull request Apr 5, 2014

Fix shapes update #7424

Merged

This was referenced Aug 30, 2021

[CLOSED] Add CSS Shapes Editor extension to Brackets brackets-archive/bracketsIssues#6660

Open

[CLOSED] Uncaught TypeError: Cannot call method '_updateStyleActiveLine' of undefined brackets-archive/bracketsIssues#6671

Open

Conversation

oslego commented Apr 2, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

larz0 commented Apr 2, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RaymondLim commented Apr 3, 2014

Uh oh!

oslego commented Apr 3, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RaymondLim commented Apr 4, 2014

Uh oh!

oslego commented Apr 4, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oslego commented Apr 4, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RaymondLim commented Apr 4, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

larz0 commented Apr 4, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants