This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Update CM SHA to cherrypicks for release 38#7401
Merged
RaymondLim merged 1 commit intomasterfrom Apr 3, 2014
Merged
Conversation
Author
|
I did some brief manual testing with these cherrypicks and didn't see anything, and the unit tests all pass. @RaymondLim - would you mind checking this for me to make sure it fixes the addressed bugs, and maybe doing a little bit of sanity testing around inline editors and general CM behavior? The main thing the fix should affect is the height of the document (in both full editors and inline editors), so be on the lookout for issues with the vertical size of the document (e.g. not being able to scroll all the way to the bottom, adding lines to the full editor or an inline editor causing strange behavior, inline editors not resizing to show all content, etc.). |
Contributor
|
Looks good. Both issues are fixed and I can't find any new issue. Merging. |
RaymondLim
added a commit
that referenced
this pull request
Apr 3, 2014
Update CM SHA to cherrypicks for release 38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This points the CM SHA to a temporary release-38-cherrypicks branch in the adobe/CodeMirror2 fork. It's essentially the CM 4.0 release plus two cherrypicked commits: