feat: disable stack traces on production#109
Merged
Conversation
LCOV of commit
|
bosschaert
reviewed
Nov 28, 2025
bosschaert
reviewed
Nov 28, 2025
bosschaert
reviewed
Nov 28, 2025
| { binding = "daadmin", service = "da-admin" } | ||
| ] | ||
|
|
||
| [vars] |
Contributor
There was a problem hiding this comment.
I think it can be useful to also report the stack traces on stage.
Contributor
Author
There was a problem hiding this comment.
i thought so, too. but currently, stage is also accessible publicly, so I would not add it by default.
bosschaert
approved these changes
Nov 28, 2025
karlpauls
approved these changes
Nov 28, 2025
adobe-bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
# 1.0.0 (2025-12-08) ### Bug Fixes * add check for shared secret ([#108](#108)) ([a79731f](a79731f)) * add span to known HTML tags ([#101](#101)) ([fbf016d](fbf016d)) * do not empty document if error ([#90](#90)) ([a406add](a406add)) * encode HTML brackets ([#100](#100)) ([6c5b5fd](6c5b5fd)) * encode HTML brackets ([#74](#74)) ([015163e](015163e)) * keep content if no main found in html ([#85](#85)) ([9fd25ac](9fd25ac)) * null doc crashes aem2doc ([#84](#84)) ([6197114](6197114)) * ommit stacktraces in error map for non-dev ([#110](#110)) ([1f896ac](1f896ac)) * remove html comments ([#68](#68)) ([cf05aae](cf05aae)) ### Features * disable stack traces on production ([#109](#109)) ([79c40bd](79c40bd)) * Prevent implicit document creation via If-Match header ([#105](#105)) ([b33ae65](b33ae65))
adobe-bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
# 1.0.0 (2025-12-08) ### Bug Fixes * add check for shared secret ([#108](#108)) ([a79731f](a79731f)) * add span to known HTML tags ([#101](#101)) ([fbf016d](fbf016d)) * do not empty document if error ([#90](#90)) ([a406add](a406add)) * encode HTML brackets ([#100](#100)) ([6c5b5fd](6c5b5fd)) * encode HTML brackets ([#74](#74)) ([015163e](015163e)) * keep content if no main found in html ([#85](#85)) ([9fd25ac](9fd25ac)) * null doc crashes aem2doc ([#84](#84)) ([6197114](6197114)) * ommit stacktraces in error map for non-dev ([#110](#110)) ([1f896ac](1f896ac)) * remove html comments ([#68](#68)) ([cf05aae](cf05aae)) * trigger release ([ca061d4](ca061d4)) ### Features * disable stack traces on production ([#109](#109)) ([79c40bd](79c40bd)) * Prevent implicit document creation via If-Match header ([#105](#105)) ([b33ae65](b33ae65))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://jira.corp.adobe.com/browse/SITES-33250