Skip to content

Comments

removing hostname restriction for ?nx parameter#767

Merged
auniverseaway merged 2 commits intomainfrom
allow-nx-branches
Feb 5, 2026
Merged

removing hostname restriction for ?nx parameter#767
auniverseaway merged 2 commits intomainfrom
allow-nx-branches

Conversation

@kmurugulla
Copy link
Contributor

Summary
Removes the client-side hostname check that was preventing the ?nx= query parameter from working on da.live and other production domains.

Changes

Removed hostname allowlist check in setNx() function
Updated test from "Does not support NX query param on prod" to "Supports NX query param on any domain"

Rationale

Repository permissions already control who can create branches in da-nx

The actual security boundary is at GitHub, not in the client-side code. Removing this check enables ?nx=local and ?nx=branch-name to work consistently in da.live

Test plan
[ ] Verify ?nx=local works on https://da.live/
[ ] Verify ?nx=branch-name works on https://da.live/
[ ] Verify existing functionality on .aem.live and .hlx. domains remains unchanged
[ ] Verify unit tests pass

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 4, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@auniverseaway auniverseaway merged commit 0f1b47c into main Feb 5, 2026
2 of 5 checks passed
@auniverseaway auniverseaway deleted the allow-nx-branches branch February 5, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants