removing hostname restriction for ?nx parameter#767
Merged
auniverseaway merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
auniverseaway
approved these changes
Feb 4, 2026
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the client-side hostname check that was preventing the ?nx= query parameter from working on da.live and other production domains.
Changes
Removed hostname allowlist check in setNx() function
Updated test from "Does not support NX query param on prod" to "Supports NX query param on any domain"
Rationale
Repository permissions already control who can create branches in da-nx
The actual security boundary is at GitHub, not in the client-side code. Removing this check enables ?nx=local and ?nx=branch-name to work consistently in da.live
Test plan
[ ] Verify ?nx=local works on https://da.live/
[ ] Verify ?nx=branch-name works on https://da.live/
[ ] Verify existing functionality on .aem.live and .hlx. domains remains unchanged
[ ] Verify unit tests pass