Skip to content

fix: open fullsize-dialogs and dialogs on first click#808

Merged
auniverseaway merged 2 commits intoadobe:mainfrom
usman-khalid:i807
Feb 25, 2026
Merged

fix: open fullsize-dialogs and dialogs on first click#808
auniverseaway merged 2 commits intoadobe:mainfrom
usman-khalid:i807

Conversation

@usman-khalid
Copy link
Copy Markdown
Contributor

@usman-khalid usman-khalid commented Feb 25, 2026

Description

In #740, this._activePane was set unconditionally before the experience type is checked in handleLibSwitch, which schedules a re-render. Moved it to after the dialog, fullsize-dialog, and window early returns so it only runs for the default inline pane path.

Related Issue

Fixes #807

How Has This Been Tested?

Screenshots (if appropriate):

BEFORE:
2026-02-25 13 24 13

AFTER:
2026-02-25 13 43 36

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Feb 25, 2026

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@auniverseaway auniverseaway merged commit 326bda6 into adobe:main Feb 25, 2026
2 of 3 checks passed
@usman-khalid usman-khalid deleted the i807 branch February 26, 2026 15:49
auniverseaway added a commit that referenced this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dialog or fullsize-dialog plugins require two clicks to open

2 participants