fix: Library 1.1#829
Merged
auniverseaway merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
* Delay da-library.js until Prose is ready * Reduced da-library.js by ~100 lines * Reduced da-library.css by ~300 lines * Simplified approach to search * Simplified and standardized approach to dialogs * Simplified approach to library loading * Simplified approach to preview handling * Standardized on existing lazy patterns * Standardized on existing render patterns for async objects * Removed all async render functions (remove until) * Rewrote all CSS from the ground up * Updated to Spectrum 2 Icons * Icons now properly change color on hover * Search improvements * Improved when scrollbars appear * Improved close library button * General fit & finish improvements * Reduced overall font size * Fixed plugin rendering being clobbered by async renders * Fixed plugin icon in dialog being broken if one was not set * Move to sl-dialog for dialogs * Fit and finish issues: templates, icons, placeholder lists are "meh" * Support generic lists Resolves: #807
10 tasks
Contributor
|
@auniverseaway — may want to update the test URL in the PR description. |
chrischrischris
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance
Complexity
User experience
Bug fixes
Not in scope
Resolves: #807
Related Issue
Motivation and Context
How Has This Been Tested?
End 2 end
https://libref--da-live--adobe.aem.live/edit#/aem-sandbox/block-collection/drafts/cmillar/demo-lib
da-library.js(and dependencies) are only loaded after prose is fully loaded.:search:{{hello}}Screenshots (if appropriate):
Types of changes
Checklist: