refactor: Modularize AEM Asset Selector into testable helpers with explicit repository mode support by ravuthu · Pull Request #841 · adobe/da-live

ravuthu · 2026-03-13T16:08:08Z

Description

Problem

The existing da-assets.js was a single ~250-line function (openAssets) that
mixed config loading, URL construction, ProseMirror insertion, smart crop UI,
approval checking, and DOM management. This made it difficult to maintain,
extend, or test. It also had a correctness bug: DM Open API delivery assets use
repo:assetId and repo:repositoryId in their response, but the old code
incorrectly read repo:id (the author-tier field) for URL construction.

Changes

Refactored `blocks/edit/da-assets/`

Split the monolith into four focused helper modules:

helpers/config.js — config fetch/cache, getConfKey, getRepositoryConfig,
getResponsiveImageConfig. getRepositoryConfig is the new central function
that resolves the three repository modes from the DA site config keys.
helpers/urls.js — three explicit URL builders, one per mode:
- buildAuthorUrl — author tier, publish URLs via asset.path
- buildDmUrl — author tier + DM delivery, uses correct asset['repo:id']
- buildDeliveryUrl — delivery tier (DM Open API), uses repo:assetId /
  repo:repositoryId / repo:name per the AEM Open API spec
- All three builders correctly route images, videos (/play), and other
  formats (PDFs, CSVs → /original/as/) to the right URL pattern.
helpers/insert.js — ProseMirror helpers: insertImage, insertLink,
insertFragment, createImageNode, findBlockContext, getBlockName.
helpers/smart-crop.js — self-contained smart crop dialog with clean
callbacks (onInsert, onBack, onCancel). Refactored crop list click
handler from li:hover to e.target.closest('li') for reliability.

da-assets.js is now a thin ~50-line orchestrator. The NX/IMS dynamic imports
are lazy (inside openAssets) so the module is importable in unit tests.

Bug fixes

Approval check in author+DM mode changed from && to ||: an asset now
requires both status === 'approved' and
activationTarget === 'delivery' to pass, not just one of them.
Videos in author+DM mode now use the /play endpoint (same as delivery tier)
instead of /original/as/.
Non-image/non-video files (PDFs, CSVs) in both DM modes now use the
/original/as/ path per the AEM Delivery API spec.
getConfKey is no longer re-exported from da-assets.js; da-library now
imports it directly from helpers/config.js.

Tests (`test/unit/blocks/edit/da-assets/`)

Added 5 new test files with 462 tests, bringing helper coverage to 100%:

File	Coverage
`helpers/config.js`	100%
`helpers/urls.js`	100%
`helpers/insert.js`	100%
`helpers/smart-crop.js`	100%
`da-assets.js`	74% (`openAssets` excluded — IMS dependency)

Configuration reference

All keys from https://docs.da.live/administrators/guides/setup-aem-assets
are supported: aem.repositoryId, aem.assets.prod.origin,
aem.assets.image.type, aem.asset.dm.delivery, aem.asset.smartcrop.select,
aem.assets.renditions.select (reserved for future use).

Related Issue

#842

Motivation and Context

How Has This Been Tested?

Tested using Chrome Dev Tools override option.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

andreas-haller · 2026-03-16T08:21:31Z

+ */
+export function buildDmUrl(asset, dmOrigin) {
+  const mimetype = asset.mimetype || asset['dc:format'] || '';
+  const base = `https://${dmOrigin}/adobe/assets/${asset['repo:id']}`;


could we enable ${dmOrigin.includes('/') ? '' : '/adobe/assets/'} again in all places where /adobe/assets/ is appended/hardcoded? It enables that if aem.assets.prod.origin is used the base path can be overwritten:

aem.assets.prod.origin=example.org -> DM path is https://example.org/adobe/assets/urn:aaid:aem:...

aem.assets.prod.origin=example.org/custom/path/ -> DM path is https://example.org/custom/path/urn:aaid:aem:...

I expect aem.assets.prod.origin to contain just the custom origin and not the base path. Even if it contains /, it doesn't guarantee that the base path is /adobe/assets/ IMHO. If we think that making the base path configurable adds value, I can create a new configuration for the base path.

@auniverseaway , thoughts?

we support it today and I'll need it for my client, the idea was that as soon as an origin with path is configured it's up to the project to make sure the right base path is present

If it is just one site, and I create a new configuration for the base path, you can then add the base path config for that site. Will that work? Because the configuration for aem.assets.prod.origin was meant to load the assets from a custom domain. Allowing the base path would not be ideal and may create confusion if adopted by more customers IMO.

Added support for custom base path configuration aem.assets.prod.basepath. Defaults to '/adobe/assets' if not configured.

andreas-haller · 2026-03-16T08:37:50Z

+  if (mimetype.startsWith('image/')) {
+    return `${base}/as/${asset.name}`;
+  }
+  if (mimetype.startsWith('video/')) {


this will change how video URLs are handled currently, I think we need a config flag here:

default can be ${base}/play to get the video player URL

if "disable video player" flag is set: ${base}/original/as/${asset.name} to enable direct URL with filename

I like the idea of having a configuration to deliver the original file for videos. I can implement one.

@auniverseaway do you agree?

maybe this can be combined with #832, looks like if that configuration can be customised we can handle also this case

This has been implemented through aem.asset.mime.renditions configuration. Images will be rendered in .avif format, videos use /play and all other files will be loaded as original by default and can be overridden by configuring the aem.asset.mime.renditions as image/*:original,video/*:original

…da-live into asset-selector-refactor

auniverseaway

This is really great stuff. Thanks for this.

sagarsane

❤️ 🎉 🚀

ravuthu added 4 commits March 13, 2026 11:49

da assets refactor

9b92763

lint errors fix

de63215

Merge branch 'main' into asset-selector-refactor

2c14927

Readme file about da-assets

9544636

andreas-haller reviewed Mar 16, 2026

View reviewed changes

Comment thread blocks/edit/da-assets/helpers/config.js Outdated

andreas-haller reviewed Mar 16, 2026

View reviewed changes

Comment thread blocks/edit/da-assets/helpers/urls.js Outdated

andreas-haller reviewed Mar 16, 2026

View reviewed changes

ravuthu added 5 commits March 16, 2026 10:56

Merge branch 'main' into asset-selector-refactor

4095156

include custom prod origin when the delivery tier Repo is configured

88386c2

Merge branch 'asset-selector-refactor' of https://github.com/ravuthu/…

a04d8e4

…da-live into asset-selector-refactor

use avif format for images

9a26486

build url refactor

ae81628

ravuthu mentioned this pull request Mar 16, 2026

fix: use correct DM delivery URLs per asset MIME type #832

Merged

6 tasks

ravuthu added 10 commits March 17, 2026 10:00

added support for base path configuration

afa512c

mimetype rendition configuration added to override the asset format

e824c3b

merge conflicts resolved

ec11d56

da assets readme update

3af3b57

Merge branch 'main' into asset-selector-refactor

0d071e2

Merge branch 'main' into asset-selector-refactor

730afc6

merge main branch - conflicts resolved

9310a96

Merge branch 'asset-selector-refactor' of https://github.com/ravuthu/…

6082df6

…da-live into asset-selector-refactor

use fetchDaConfigs instead of daFetch to avoid multiple network calls

8b1c88d

show error message when an asset is not available on publish tier

ce2f628

auniverseaway approved these changes Mar 23, 2026

View reviewed changes

sagarsane reviewed Mar 23, 2026

View reviewed changes

auniverseaway merged commit 2d37fac into adobe:main Mar 23, 2026
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Modularize AEM Asset Selector into testable helpers with explicit repository mode support#841

refactor: Modularize AEM Asset Selector into testable helpers with explicit repository mode support#841
auniverseaway merged 19 commits intoadobe:mainfrom
ravuthu:asset-selector-refactor

ravuthu commented Mar 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

andreas-haller Mar 16, 2026

Uh oh!

ravuthu Mar 16, 2026

Uh oh!

andreas-haller Mar 16, 2026

Uh oh!

ravuthu Mar 16, 2026 •

edited

Loading

Uh oh!

ravuthu Mar 17, 2026

Uh oh!

Uh oh!

andreas-haller Mar 16, 2026

Uh oh!

ravuthu Mar 16, 2026

Uh oh!

andreas-haller Mar 16, 2026

Uh oh!

ravuthu Mar 17, 2026 •

edited

Loading

Uh oh!

auniverseaway left a comment

Uh oh!

sagarsane left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ravuthu commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Changes

Refactored blocks/edit/da-assets/

Bug fixes

Tests (test/unit/blocks/edit/da-assets/)

Configuration reference

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

Uh oh!

andreas-haller Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ravuthu Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

andreas-haller Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ravuthu Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ravuthu Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andreas-haller Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ravuthu Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

andreas-haller Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ravuthu Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auniverseaway left a comment

Choose a reason for hiding this comment

Uh oh!

sagarsane left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ravuthu commented Mar 13, 2026 •

edited

Loading

Refactored `blocks/edit/da-assets/`

Tests (`test/unit/blocks/edit/da-assets/`)

ravuthu Mar 16, 2026 •

edited

Loading

ravuthu Mar 17, 2026 •

edited

Loading