feat: NX2 - support custom background images and dark scheme on da-sites#870
Merged
auniverseaway merged 4 commits intomainfrom Apr 29, 2026
Merged
feat: NX2 - support custom background images and dark scheme on da-sites#870auniverseaway merged 4 commits intomainfrom
auniverseaway merged 4 commits intomainfrom
Conversation
chrischrischris
previously approved these changes
Apr 16, 2026
- Pass background element from browse block into da-sites component - Replace hardcoded hex colors with --s2-* CSS variables - Add gradient mask on background image - Set color scheme from localStorage/media query before render - Load utils.js early and hide HTML to prevent FOUC - Select LCP images based on active color scheme
hannessolo
previously approved these changes
Apr 29, 2026
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
chrischrischris
approved these changes
Apr 29, 2026
chrischrischris
pushed a commit
that referenced
this pull request
May 1, 2026
…tes (#870) * feat: nx2 + browse - Pass background element from browse block into da-sites component - Replace hardcoded hex colors with --s2-* CSS variables - Add gradient mask on background image - Set color scheme from localStorage/media query before render - Load utils.js early and hide HTML to prevent FOUC - Select LCP images based on active color scheme * fix test and package-lock * fix: Use Node.js 22 instead of non-existent version 24 * fix: Reset package-lock.json to main branch version Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
DA.LIVE prod + NX1 + old images
https://dasites--da-live--adobe.aem.live/
Expectation: everything works E2E
DA.LIVE stage + NX2 + new images
https://dasites--da-live--adobe.aem.page/?nx=nx2fixes&nxver=2
Expectation: only da homepage works, but is correctly styled
Screenshots (if appropriate):
Types of changes
Checklist: