Skip to content

feat: Delete enhancements#888

Merged
chrischrischris merged 1 commit into
mainfrom
ccc-861
Apr 28, 2026
Merged

feat: Delete enhancements#888
chrischrischris merged 1 commit into
mainfrom
ccc-861

Conversation

@chrischrischris
Copy link
Copy Markdown
Contributor

@chrischrischris chrischrischris commented Apr 22, 2026

Implement total count and max amount of items to delete allowed.

I upped the max delete amount to 1000 for now. Or should we make it configurable?

Implements part of #861

Screenshot 2026-04-22 at 3 58 28 PM Screenshot 2026-04-28 at 3 34 34 PM Screenshot 2026-04-28 at 3 34 59 PM

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 22, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@kptdobe
Copy link
Copy Markdown
Contributor

kptdobe commented Apr 27, 2026

Re-thinking about it.. there are always scenarii where you really want to delete a folder with a lot of mess in it.

What about something like:

  • if less than 10, delete
  • between 10 and 1000, user has to write "DELETE" to confirm this is really what they want to do
  • contact admin if more than 1000

WDYT ?

@auniverseaway auniverseaway self-requested a review April 28, 2026 00:55
Copy link
Copy Markdown
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1000 is fine.

@auniverseaway
Copy link
Copy Markdown
Member

I like @kptdobe suggestions.

Implement total count and max amount of items to delete allowed
@chrischrischris chrischrischris merged commit b2cf02d into main Apr 28, 2026
3 of 4 checks passed
@chrischrischris chrischrischris deleted the ccc-861 branch April 28, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants