Skip to content

feat: chat prompt picker#375

Merged
sharanyavinod merged 6 commits intoewfrom
ew-prompts
Apr 23, 2026
Merged

feat: chat prompt picker#375
sharanyavinod merged 6 commits intoewfrom
ew-prompts

Conversation

@sharanyavinod
Copy link
Copy Markdown

Includes:

  • Prompt picker which opens on "Load More" on the chat welcome screen if prompts are available AND on chat input add menu -> prompt
  • Combobox includes options to filter by category and search by title/description

Preview available at https://da.live/canvas?nx=ew-prompts&nxver=2#/aem-sandbox/block-collection/ew-test

Screenshot 2026-04-21 at 11 45 05

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 21, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@hannessolo
Copy link
Copy Markdown
Contributor

  • Should we have an option to add the prompt to the chat instead of firing it directly?
  • Should typing / in the chat box also open this prompt menu?

@sharanyavinod
Copy link
Copy Markdown
Author

  • Should we have an option to add the prompt to the chat instead of firing it directly?

Indeed would be nice. I'll check with Kilian as a followup, since if we add it would need to add on the welcome screen prompts as well.

  • Should typing / in the chat box also open this prompt menu?

As per both the mocks and the existing implementation on exp-workspace branch, slash menu shows the available DA tools and skills. The menu we have currently also cleanly separates prompts vs slash menu. Wdyt? Confusing?

Screenshot 2026-04-22 at 08 29 59

@anfibiacreativa
Copy link
Copy Markdown
Member

  • Should we have an option to add the prompt to the chat instead of firing it directly?
  • Should typing / in the chat box also open this prompt menu?

Actually this was the behavior from the prompt management and quick skills editor. That allows users to edit the prompts when needed.

Comment thread nx2/blocks/chat/prompts/prompts.js
Comment thread nx2/blocks/chat/chat.js Outdated
Comment thread nx2/blocks/chat/chat.js
updated(changed) {
if (changed.has('messages')) {
const log = this.shadowRoot.querySelector('.chat-messages-container');
const log = this.shadowRoot.querySelector('.chat-scroll-container');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move selectors we're querying to constants to prevent regressions?

Copy link
Copy Markdown
Author

@sharanyavinod sharanyavinod Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is a recurring pattern. Will create a followup PR to collate all such usages across chat.

@hannessolo
Copy link
Copy Markdown
Contributor

Wdyt? Confusing?

I don't think it's confusing (although I'm not sure I understand what selecting a tool from the / menu will do), but I think it's too many clicks to run a prompt - click +, click prompts, select prompt

Vs if we integrated it with the / menu (slash would be combo of commands and skills), it's just type / and select prompt.

@sharanyavinod
Copy link
Copy Markdown
Author

Wdyt? Confusing?

I don't think it's confusing (although I'm not sure I understand what selecting a tool from the / menu will do), but I think it's too many clicks to run a prompt - click +, click prompts, select prompt

Vs if we integrated it with the / menu (slash would be combo of commands and skills), it's just type / and select prompt.

Regarding clicks, true I agree. But then the slash menu becomes a pot of all different things ie prompts,commands,skills so that would need to be much cleaner and clearer than what we have atm. I would say we keep it as is for now, and follow up from the ux side whether these should also be present within the / menu. Adding it should be straightforward if we decide to do so anyway.

@anfibiacreativa
Copy link
Copy Markdown
Member

@sharanyavinod Do you want to start writing e2e tests with this feature?

@sharanyavinod
Copy link
Copy Markdown
Author

@sharanyavinod Do you want to start writing e2e tests with this feature?

Do we start already, or post move to da live?

cc @hannessolo

@sharanyavinod
Copy link
Copy Markdown
Author

sharanyavinod commented Apr 22, 2026

I was also thinking - instead of a magical / which does everything, why not something like slack ie type/ shows the different options like /prompt /skill etc and selecting that opens the follow up menu with filter search etc like we have prompts today. Just an easier way of triggering prompts and others aligned to existing standards, and already includes control if any of these lists grows too much without overwhelming the end user. Thoughts?

Of course, nothing to be considered within the scope of this PR but more for when we implement slash menu.

@hannessolo
Copy link
Copy Markdown
Contributor

Do we start already, or post move to da live?

I don't mind. Before we merge to da-live the tests are quite decoupled anyway.

@mhaack
Copy link
Copy Markdown
Contributor

mhaack commented Apr 22, 2026

In the Screenshot it says "DA Commands" this should be "Experience Workspace Commands" or if too long maybe just "Commands".

@hannessolo
Copy link
Copy Markdown
Contributor

In the Screenshot it says "DA Commands" this should be "Experience Workspace Commands" or if too long maybe just "Commands".

I don't think the slash menu is implemented yet, that screenshot is from figma. We discussed in the daily today that we hold off the slash menu for now until we clarify where which types of items should show up (and whether we even need skills vs commands).

@sharanyavinod
Copy link
Copy Markdown
Author

@anfibiacreativa I discussed with @hannessolo as well, and I feel it might be too complicated to already start with tests while our changes are still across repos/branches. Would prefer to hold on adding them, until after we move to da-live.
For now, I would keep tests out of scope of this PR.

@sharanyavinod sharanyavinod merged commit a31a35f into ew Apr 23, 2026
3 checks passed
@sharanyavinod sharanyavinod deleted the ew-prompts branch April 23, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants