Skip to content

feat: file explorer#416

Merged
sharanyavinod merged 7 commits into
ewfrom
ew-files
May 5, 2026
Merged

feat: file explorer#416
sharanyavinod merged 7 commits into
ewfrom
ew-files

Conversation

@sharanyavinod
Copy link
Copy Markdown

  • Introduces file explorer section in right panel
  • Extracts shared logic in browse to utils
  • Extracts shared keydown logic for tree
  • Preserves selected section in right panel within a session

Preview at https://da.live/canvas?nx=ew-files&nxver=2#/exp-workspace/frescopa/index

sharanyavinod and others added 4 commits May 5, 2026 09:33
Full-height inset grip with 2px --s2-gray-400 rail, opacity reveal
after 0.2s on hover/focus, immediate on active for drag.

Co-authored-by: kamendola <amendola@adobe.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 5, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@hannessolo
Copy link
Copy Markdown
Contributor

Screenshot 2026-05-05 at 13 33 15

I'm not sure about the UI change, the official figma for the EC chat UI uses it the way we have now: https://www.figma.com/design/k57pA6SBNlKMCnnSp3xYqd/S2---EC-Patterns?node-id=4036-26556&t=jpgdD3EtH4gbmukv-0

Copy link
Copy Markdown
Contributor

@hannessolo hannessolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we will need to distinguish between pages and sheets in the file browser too (with icons). Since we don't have sheet support yet I'm fine with deferring

Comment thread nx2/blocks/canvas/nx-panel-extensions/helpers.js Outdated
@sharanyavinod
Copy link
Copy Markdown
Author

At some point we will need to distinguish between pages and sheets in the file browser too (with icons). Since we don't have sheet support yet I'm fine with deferring

Yup, makes sense to do them in a generic way across browse and explore once we have support

@kamendola
Copy link
Copy Markdown

@hannessolo We are not using the EC default app frame in this context, and mostly we want to clean the UI from any visual that are not critical or important for the users in this context.
Plus there is no Spectrum strict guidelines for resize as every app, solutions have to use what's work for them. The solution here met all the Spectrum design and accessibility requirements.

@sharanyavinod sharanyavinod requested a review from hannessolo May 5, 2026 12:03
@hannessolo
Copy link
Copy Markdown
Contributor

Ok, @sharanyavinod can you move that change to a separate PR though? The issue is that the resizing/panels are not something that is scoped to our block, but rather part of the nx shell, so we should review it as a stand-alone.

@sharanyavinod
Copy link
Copy Markdown
Author

@hannessolo Sure but that's not in this PR if it helps, that change is within #414 and I can move it out of there

@hannessolo
Copy link
Copy Markdown
Contributor

Oh, oops. Confused by too many PRs.

Base automatically changed from ew-move to ew May 5, 2026 14:19
@sharanyavinod sharanyavinod merged commit e1228e6 into ew May 5, 2026
3 checks passed
@sharanyavinod sharanyavinod deleted the ew-files branch May 5, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants