fix(chat): wire up Skills Editor prompt + and ▶ buttons#489
Open
anfibiacreativa wants to merge 1 commit into
Open
fix(chat): wire up Skills Editor prompt + and ▶ buttons#489anfibiacreativa wants to merge 1 commit into
anfibiacreativa wants to merge 1 commit into
Conversation
The Skills Editor (ew-extensions) prompt cards dispatch `prompt-add` / `prompt-send` on a `da-skills-editor` BroadcastChannel and as window CustomEvents, but `nx-chat` never subscribed — so clicking + or ▶ was a no-op on the chat side. Add a small bridge in connectedCallback that listens on both transports, dedupes the editor's double-dispatch, and routes prompt-add to fill the input only and prompt-send to fill + submit. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
hannessolo
reviewed
Jun 2, 2026
| // The editor's `+` (add) and `▶` (run) buttons post `prompt-add` / `prompt-send` | ||
| // on this BroadcastChannel and as window CustomEvents. | ||
| const SKILLS_CHANNEL = 'da-skills-editor'; | ||
| const SKILLS_PROMPT_ADD_EVENTS = [ |
Contributor
There was a problem hiding this comment.
I don't think this code should know about the skills editor. We should just have a generic event that we can send on the chat component that sets the prompt.
Contributor
There was a problem hiding this comment.
+1 - I would look into extending the existing add-to-chat event to also accept prompt instead
Contributor
There was a problem hiding this comment.
+1 we should proceed with the generic approach which can be used by others as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Skills Editor (ew-extensions) prompt cards dispatch
prompt-add/prompt-sendon ada-skills-editorBroadcastChannel and as window CustomEvents, butnx-chatnever subscribed — so clicking + or ▶ was a no-op on the chat side. Add a small bridge in connectedCallback that listens on both transports, dedupes the editor's double-dispatch, and routes prompt-add to fill the input only and prompt-send to fill + submit.Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):