fix(discover): reindex all no longer worked #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+191
to
+195
| // do not search for custom users in org/sites that | ||
| // are not listed in env.HLX_CUSTOM_GOOGLE_USERS | ||
| if (!this.customUserProjects.some((project) => project.match(entry))) { | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
noticed in reindex all, that we had an enormous amount of checks for custom users in every google backed project, although we won't include them when searching for google documents
Comment on lines
+124
to
+127
| const matchers = Object.fromEntries( | ||
| Object.entries(MATCHERS) | ||
| .map(([name, Matcher]) => [name, new Matcher(context.env)]), | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
create all matchers once for the whole reindex operation
tripodsan
approved these changes
Nov 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2025
## [1.15.2](v1.15.1...v1.15.2) (2025-11-15) ### Bug Fixes * **discover:** reindex all no longer worked ([#37](#37)) ([827d228](827d228))
|
🎉 This PR is included in version 1.15.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with our changes to
bucket.list(shallow), reindexing no longer worked: listing the children of anorgreturned an empty array.