fix: inject hlx:proxyUrl meta for local content/ pages#2753
Merged
Conversation
Sidekick relies on hlx:proxyUrl to resolve the edit source. It was only injected for proxied responses, so pages served from the local content/ checkout during `aem up` lacked it, breaking sidekick edit detection. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rofe
approved these changes
Jul 3, 2026
tripodsan
approved these changes
Jul 6, 2026
Contributor
|
🎉 This PR is included in version 16.20.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aem upserved pages from a localcontent/checkout without thehlx:proxyUrlmeta tag that the proxy path already injects, so the sidekick couldn't resolve the edit source for those pages.hlx:proxyUrl(pointing at the equivalent proxy URL) into HTML served fromcontent/, matching what already happens for proxied responses.Test plan
test/server.test.js(content/ serving), confirmed it fails without the fix and passes with itnpm run lintnpx mocha test/server.test.js(pre-existing unrelated flake around port 3000 reuse, reproduces onmaintoo)🤖 Generated with Claude Code