Skip to content

Fixing docker build#87

Merged
sean-parent merged 1 commit intomasterfrom
sparent/docker-fixes
Jun 11, 2024
Merged

Fixing docker build#87
sean-parent merged 1 commit intomasterfrom
sparent/docker-fixes

Conversation

@sean-parent
Copy link
Copy Markdown
Contributor

Description

  • Speedup and simplify docker build
  • Fix compiler errors when building with clang-15
  • Update readme on building with docker
  • Minor reformatting (using existing .clang-format file)

Related Issue

I'm pushing a 2.0.1 Hyde docker image to an associated package (I've never done an associated package... so we'll see if it works!)

After the commit happens, I'll review the outstanding issues and comment (I know there is one on using Hyde on Windows, this is a good solution).

Motivation and Context

The docker image wasn't building; when it was last built, it was a hack. I needed it working to update the stlab docs.

How Has This Been Tested?

I'm using this to update stlab docs.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Speedup and simplify docker build
- Fix compiler errors when building with clang-15
- Update readme on building with docker
- Minor reformatting (using existing `.clang-format` file)
@sean-parent sean-parent merged commit 330da09 into master Jun 11, 2024
@sean-parent sean-parent deleted the sparent/docker-fixes branch June 11, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant