[bug-fix] - Cluster Status Never Updated#235
Merged
dvaseekara merged 1 commit intomasterfrom Mar 3, 2026
Merged
Conversation
azun
approved these changes
Mar 2, 2026
dobrerazvan
approved these changes
Mar 3, 2026
|
@dvaseekara can this be prevented with an integration test? |
hvan
previously requested changes
Mar 3, 2026
Collaborator
Author
Yes, it can! Adding a story for this sprint to add integration test. Should be fairly simple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cluster status was not being updated anymore due to a pre-mature return call. I assume the idea in introducing the removed lines was that the controller-runtime or the kafka reconciler would update the Cluster Status but this is not the case.
Reverting code to allow the Reconcile method in kafkacluster_controller.go to update the cluster status to "ClusterRunning"