Skip to content

Conversation

@kmaschi
Copy link
Member

@kmaschi kmaschi commented Oct 31, 2024

Description

Wrap newrelic agent usage in an barebones abstraction of a telemetry agent. Implemented a log agent as fallback.

Related Issue

CEXT-2904

Motivation and Context

Existing code required newrelic as a dependency which forced opinions on consumers.

How Has This Been Tested?

  • Linked to mesh builder.
  • Linked to legacy api mesh.
  • Linked to edge mesh.
  • Linked to sms.

Include plugin in projects that do not have newrelic as a dependency. Mesh should build and function without error.
Include plugin in projects that do have newrelic as a dependency. Mesh should build and function without error, sending telemetry to newrelic when application is configured to do so.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kmaschi kmaschi merged commit 03e251a into develop Oct 31, 2024
4 checks passed
@kmaschi kmaschi deleted the feature/CEXT-2904-make-newrelic-optional branch October 31, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants