epic/new hooks #33
Merged
epic/new hooks #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added package build configuration for esm/cjs
- Added tests. - Refactoring for tests.
Chore/ts port
chore: - Updated tests to ensure expected payload passed into hook fu…
Member
Author
|
Created as epic to test NPM publish. |
kmaschi
requested review from
amolina-adobe,
brasewel,
jward-magento and
revanth0212
as code owners
dani97
reviewed
Jun 23, 2025
dani97
force-pushed
the
epic/ts-migration
branch
from
dc31d32 to
451949c
Compare
amolina-adobe
previously approved these changes
Jul 31, 2025
… types. - Updated remote hook payload to only include appropriate serializable context.
- Moved error handling related functions to error module. - Added copyright notices in new files.
- Added jsdocs.
Feature/cext 4829 context state
Chore/plugin hooks fixes
…ferently. - Updated types to make clear the properties available to each hook handler. - Handled stacked beforeAll/afterAll hooks ensuring both local and remove functions can work with serialized payload. - Handled stacked beforeAll/afterAll hooks ensuring handlers can work with serialized response data. - Updated tests.
Chore/sourcehooks remote fix
amolina-adobe
previously approved these changes
Aug 5, 2025
brasewel
previously approved these changes
Aug 6, 2025
Updating readme. Excluding examples
brasewel
approved these changes
Aug 6, 2025
amolina-adobe
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes features and fixes for the plugin-hooks repository.
Description
Current state of this project is in JS with very minimal/non-existent test coverage. Moving forward we would like to have confidence in changes through test coverage. The move to TypeScript will improve developer experience working within the package and provide useful typings that can be used by users creating hooks.
BeforeSource hook executes once before the fetch to a named source. It has access to the request allowing users to perform actions such as modifying request headers.
AfterSource hook executes once after the fetch to a named source. It has access to the response allowing users to perform actions such as modifying response headers.
AfterAll hook executes once before the final response is sent to the client.
Related Issue
CEXT-1441
Motivation and Context
Goals of better developer and user experience.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: