Skip to content

feat: add support to display both solid and hollow static points#747

Merged
madelineluke merged 6 commits intomainfrom
feat/support-multiple-static-point-styles
Mar 31, 2026
Merged

feat: add support to display both solid and hollow static points#747
madelineluke merged 6 commits intomainfrom
feat/support-multiple-static-point-styles

Conversation

@madelineluke
Copy link
Copy Markdown
Collaborator

@madelineluke madelineluke commented Mar 31, 2026

Description

Before this change, the Line chart could only display all solid static points, or all hollow (sparkline) static points. This update makes it so both types of static points can display on the line. The user can use the staticPoint prop that already exists to key to a property in the data that is set to either 'solid' or 'hollow'.

Related Issue

Motivation and Context

Allows 2 different types of static points to display on the line at the same time.

How Has This Been Tested?

Storybook, unit tests.

Screenshots (if appropriate):

Screenshot 2026-03-31 at 9 27 05 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@c-lamoureux
Copy link
Copy Markdown
Contributor

Solid points aren't in the s2 design spec, do we need to support this feature for both the s1 and s2 packages?

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

@madelineluke madelineluke merged commit 83f80f9 into main Mar 31, 2026
6 checks passed
@madelineluke madelineluke deleted the feat/support-multiple-static-point-styles branch March 31, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants