feat: add support to display both solid and hollow static points#747
Merged
madelineluke merged 6 commits intomainfrom Mar 31, 2026
Merged
feat: add support to display both solid and hollow static points#747madelineluke merged 6 commits intomainfrom
madelineluke merged 6 commits intomainfrom
Conversation
…default to filled
…s into feat/support-multiple-static-point-styles
…arkline functionality
Contributor
|
Solid points aren't in the s2 design spec, do we need to support this feature for both the s1 and s2 packages? |
|
c-lamoureux
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Before this change, the Line chart could only display all solid static points, or all hollow (sparkline) static points. This update makes it so both types of static points can display on the line. The user can use the staticPoint prop that already exists to key to a property in the data that is set to either 'solid' or 'hollow'.
Related Issue
Motivation and Context
Allows 2 different types of static points to display on the line at the same time.
How Has This Been Tested?
Storybook, unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: