Skip to content

feat: metric range hover fixes #773

Merged
madelineluke merged 2 commits intomainfrom
feat/metric-range-display-on-hover-options
Apr 21, 2026
Merged

feat: metric range hover fixes #773
madelineluke merged 2 commits intomainfrom
feat/metric-range-display-on-hover-options

Conversation

@madelineluke
Copy link
Copy Markdown
Collaborator

Description

The getVoronoiYEncoding helper function creates y encoding for voronoi points, so that the hoverable metric range points are included. This helper function needs to be used for the yEncoding prop when creating the hover area. The getVoronoiYEncoding function falls back to getLineYEncoding when there are no metric range hover points.

Related Issue

Motivation and Context

When using the metric range displayOnHover prop

How Has This Been Tested?

Visually and unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…o metric range points are included correctly. if there are no metric range hover points, this helper func will fallback to getLineYEncoding
@sonarqubecloud
Copy link
Copy Markdown

@madelineluke madelineluke changed the title Feat/metric range display on hover options feat: metric range hover fixes Apr 21, 2026
@github-actions
Copy link
Copy Markdown

@madelineluke madelineluke merged commit 247ad02 into main Apr 21, 2026
6 checks passed
@madelineluke madelineluke deleted the feat/metric-range-display-on-hover-options branch April 21, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants