GridList item data-focus-visible is set after a drop action

[ProTip]

Provide a general summary of the issue here

Aria component GridList documents item data-focus-visible as being "Whether the item is currently keyboard focused.".

However, it appears to be getting set after a drop operation completes on the list.

🤔 Expected Behavior?

The item is not focused because a keyboard action did not occur.

😯 Current Behavior

Item has the data-focus-visible attribute set.

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

This is observable in the first drag-and-drop example in the documentation: https://react-spectrum.adobe.com/react-aria/GridList.html#drag-and-drop .

Version

1.0.0-nightly.4070

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Windows, Linux

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

[reidbarber]

This is the expected behavior currently:

react-spectrum/packages/@react-aria/dnd/src/useDroppableCollection.ts

Lines 252 to 254 in be50125

	// If focus didn't move already (e.g. due to an insert), and the user dropped on an item,
	// focus that item and show the focus ring to give the user feedback that the drop occurred.
	// Also show the focus ring if the focused key is not selected, e.g. in case of a reorder.

I can see how it may be too opinionated, but it I'm not sure it's better not to include this behavior. I can bring this up with the team to discuss.

[dawi]

May I ask if there’s a way to opt out of that behavior by now?

I am also facing this issue using dnd in the using dnd in the tree component.

To others I can explain, why the outline is useful during keyboard interactions.
But it's harder to explain why it suddenly appears during mouse interactions.

[snowystinger]

Nothing yet, we haven't had priority for this. The fastest way to get it going again would be to make a contribution https://react-spectrum.adobe.com/contribute.html