Contribution issues

[unional]

Provide a general summary of the issue here

This issues tracks all problems occurred when trying to contribute to the repo.

Will see if we can update the CONTRIUBTION.md or any process adjustments can be made.

• yarn install
• yarn start
• yarn jest

7 Test failures

Summary of all failing tests
 FAIL  packages/@react-spectrum/list/test/ListView.test.js (48.986 s)
  ● ListView › height 0 › should render and not infinite loop

    expect(element).toBeEmptyDOMElement()

    Received:
      "<div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"0\" id=\"react-aria-«r1oq»-0\" role=\"row\" aria-label=\"Item 0\" aria-rowindex=\"1\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem react-spectrum-ListViewItem--firstRow\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 0</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"1\" id=\"react-aria-«r1oq»-1\" role=\"row\" aria-label=\"Item 1\" aria-rowindex=\"2\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 1</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"2\" id=\"react-aria-«r1oq»-2\" role=\"row\" aria-label=\"Item 2\" aria-rowindex=\"3\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 2</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"3\" id=\"react-aria-«r1oq»-3\" role=\"row\" aria-label=\"Item 3\" aria-rowindex=\"4\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 3</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"4\" id=\"react-aria-«r1oq»-4\" role=\"row\" aria-label=\"Item 4\" aria-rowindex=\"5\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 4</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"5\" id=\"react-aria-«r1oq»-5\" role=\"row\" aria-label=\"Item 5\" aria-rowindex=\"6\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 5</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"6\" id=\"react-aria-«r1oq»-6\" role=\"row\" aria-label=\"Item 6\" aria-rowindex=\"7\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 6</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"7\" id=\"react-aria-«r1oq»-7\" role=\"row\" aria-label=\"Item 7\" aria-rowindex=\"8\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 7</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"8\" id=\"react-aria-«r1oq»-8\" role=\"row\" aria-label=\"Item 8\" aria-rowindex=\"9\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 8</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"9\" id=\"react-aria-«r1oq»-9\" role=\"row\" aria-label=\"Item 9\" aria-rowindex=\"10\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 9</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"10\" id=\"react-aria-«r1oq»-10\" role=\"row\" aria-label=\"Item 10\" aria-rowindex=\"11\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 10</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"11\" id=\"react-aria-«r1oq»-11\" role=\"row\" aria-label=\"Item 11\" aria-rowindex=\"12\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 11</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"12\" id=\"react-aria-«r1oq»-12\" role=\"row\" aria-label=\"Item 12\" aria-rowindex=\"13\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 12</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"13\" id=\"react-aria-«r1oq»-13\" role=\"row\" aria-label=\"Item 13\" aria-rowindex=\"14\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 13</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"14\" id=\"react-aria-«r1oq»-14\" role=\"row\" aria-label=\"Item 14\" aria-rowindex=\"15\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 14</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"15\" id=\"react-aria-«r1oq»-15\" role=\"row\" aria-label=\"Item 15\" aria-rowindex=\"16\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 15</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"16\" id=\"react-aria-«r1oq»-16\" role=\"row\" aria-label=\"Item 16\" aria-rowindex=\"17\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 16</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"17\" id=\"react-aria-«r1oq»-17\" role=\"row\" aria-label=\"Item 17\" aria-rowindex=\"18\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 17</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"18\" id=\"react-aria-«r1oq»-18\" role=\"row\" aria-label=\"Item 18\" aria-rowindex=\"19\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 18</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div><div role=\"presentation\" style=\"position: absolute; overflow: visible; opacity: 1; z-index: 0; contain: size layout style; top: 0px; left: 0px; width: 0px; height: 0px;\"><div tabindex=\"-1\" data-collection=\"react-aria-«r1op»\" data-key=\"19\" id=\"react-aria-«r1oq»-19\" role=\"row\" aria-label=\"Item 19\" aria-rowindex=\"20\" class=\"react-spectrum-ListView-row round-tops round-bottoms\"><div class=\"react-spectrum-ListViewItem react-spectrum-ListViewItem--lastRow react-spectrum-ListViewItem--isFlushBottom\" role=\"gridcell\" aria-colindex=\"1\"><div style=\"display: grid;\" class=\"react-spectrum-ListViewItem-grid\"><span role=\"none\" class=\"react-spectrum-ListViewItem-content\">Item 19</span><svg class=\"spectrum-Icon spectrum-UIIcon-ChevronRightMedium react-spectrum-ListViewItem-parentIndicator is-disabled\" focusable=\"false\" aria-hidden=\"true\" role=\"img\"><path d=\"M5.99 5a.997.997 0 0 0-.293-.707L1.717.303A1 1 0 1 0 .303 1.717L3.586 5 .303 8.283a1 1 0 1 0 1.414 1.414l3.98-3.99A.997.997 0 0 0 5.99 5z\"></path></svg></div></div></div></div>"

      1723 |         jest.runAllTimers();
      1724 |       });
    > 1725 |       expect(grid.firstChild).toBeEmptyDOMElement();
           |                               ^
      1726 |     });
      1727 |   });
      1728 | });

      at Object.toBeEmptyDOMElement (packages/@react-spectrum/list/test/ListView.test.js:1725:31)

 FAIL  packages/@react-spectrum/labeledvalue/test/LabeledValue.test.js
  ● LabeledValue › renders correctly with RangeValue<NumberValue>

    expect(element).toHaveTextContent()

    Expected element to have text content:
      Field label10–20
    Received:
      Field label10 – 20

      273 |     let staticField = getByTestId('test-id');
      274 |     expect(staticField).toBeInTheDocument();
    > 275 |     expect(staticField).toHaveTextContent('Field label10–20');
          |                         ^
      276 |   });
      277 |
      278 |   it('renders correctly with ReactElement value', function () {

      at Object.toHaveTextContent (packages/@react-spectrum/labeledvalue/test/LabeledValue.test.js:275:25)

 FAIL  packages/@react-aria/dnd/test/DropTargetKeyboardNavigation.test.tsx
  ● drop target keyboard navigation › sanity test collection

    TypeError: expectedKeys.toReversed is not a function

      267 |     }
      268 |
    > 269 |     expect(prevKeys).toEqual(expectedKeys.toReversed());
          |                                           ^
      270 |   });
      271 |
      272 |   function collect(keyboardDelegate: KeyboardDelegate, direction: 'up' | 'down' | 'left' | 'right', rtl = false) {

      at Object.toReversed (packages/@react-aria/dnd/test/DropTargetKeyboardNavigation.test.tsx:269:43)

  ● drop target keyboard navigation › should navigate backward vertically

    TypeError: results.toReversed is not a function

      291 |     let keyboardDelegate = new ListKeyboardDelegate(collection, new Set(), createRef());
      292 |     let results = collect(keyboardDelegate, 'up');
    > 293 |     expect(results.toReversed()).toEqual(expectedTargets);
          |                    ^
      294 |   });
      295 |
      296 |   it('should navigate forward horizontally (ltr)', () => {

      at Object.toReversed (packages/@react-aria/dnd/test/DropTargetKeyboardNavigation.test.tsx:293:20)

  ● drop target keyboard navigation › should navigate backward horizontally (ltr)

    TypeError: results.toReversed is not a function

      327 |
      328 |     let results = collect(keyboardDelegate, 'left');
    > 329 |     expect(results.toReversed()).toEqual(expectedTargets);
          |                    ^
      330 |   });
      331 |
      332 |   it('should navigate backward horizontally (rtl)', () => {

      at Object.toReversed (packages/@react-aria/dnd/test/DropTargetKeyboardNavigation.test.tsx:329:20)

  ● drop target keyboard navigation › should navigate backward horizontally (rtl)

    TypeError: results.toReversed is not a function

      339 |
      340 |     let results = collect(keyboardDelegate, 'right', true);
    > 341 |     expect(results.toReversed()).toEqual(expectedTargets);
          |                    ^
      342 |   });
      343 | });
      344 |

      at Object.toReversed (packages/@react-aria/dnd/test/DropTargetKeyboardNavigation.test.tsx:341:20)

 FAIL  packages/@internationalized/date/tests/DateFormatter.test.js
  ● DateFormatter › should work around buggy hour12 behavior

    expect(received).toBe(expected) // Object.is equality

    Expected: "午前12時"
    Received: "午前0時"

      79 |
      80 |     formatter = new DateFormatter('ja', {hour: 'numeric', hour12: true});
    > 81 |     expect(formatter.format(new Date(2020, 1, 3, 0))).toBe('午前12時');
         |                                                       ^
      82 |     expect(formatter.resolvedOptions().hourCycle).toBe('h12');
      83 |   });
      84 |

      at Object.toBe (packages/@internationalized/date/tests/DateFormatter.test.js:81:55)


Test Suites: 4 failed, 328 passed, 332 total
Tests:       7 failed, 46 skipped, 7178 passed, 7231 total
Snapshots:   242 passed, 242 total
Time:        273.426 s

When running yarn jest again, failed test is reduced to only the first one.

• yarn build

While I mentioned about the type errors in the past, it actually fails right now:

Build failure

Error: Bundles must have unique names. Conflicting names: packages/@react-spectrum/actiongroup/dist/vars.css, 
packages/@react-spectrum/actiongroup/dist/vars.cjs, packages/@react-spectrum/actiongroup/dist/vars.mjs, 
packages/@react-spectrum/autocomplete/dist/vars.css, packages/@react-spectrum/autocomplete/dist/vars.cjs, 
packages/@react-spectrum/autocomplete/dist/vars.css, packages/@react-spectrum/autocomplete/dist/vars.cjs, 
packages/@react-spectrum/autocomplete/dist/vars.mjs, packages/@react-spectrum/autocomplete/dist/vars.mjs, 
packages/@react-spectrum/checkbox/dist/vars.css, packages/@react-spectrum/checkbox/dist/vars.cjs, 
packages/@react-spectrum/checkbox/dist/vars.mjs, packages/@react-spectrum/color/dist/vars.css, 
packages/@react-spectrum/color/dist/vars.cjs, packages/@react-spectrum/color/dist/vars.css, 
packages/@react-spectrum/color/dist/vars.cjs, packages/@react-spectrum/color/dist/vars.css, 
packages/@react-spectrum/color/dist/vars.cjs, packages/@react-spectrum/color/dist/vars.css, 
packages/@react-spectrum/color/dist/vars.cjs, packages/@react-spectrum/color/dist/vars.mjs, 
packages/@react-spectrum/color/dist/vars.mjs, packages/@react-spectrum/color/dist/vars.mjs, 
packages/@react-spectrum/color/dist/vars.mjs, packages/@react-spectrum/combobox/dist/vars.css, 
packages/@react-spectrum/combobox/dist/vars.cjs, packages/@react-spectrum/combobox/dist/vars.css, 
packages/@react-spectrum/combobox/dist/vars.cjs, packages/@react-spectrum/combobox/dist/vars.css, 
packages/@react-spectrum/combobox/dist/vars.cjs, packages/@react-spectrum/combobox/dist/vars.css, 
packages/@react-spectrum/combobox/dist/vars.cjs, packages/@react-spectrum/combobox/dist/vars.mjs, 
packages/@react-spectrum/combobox/dist/vars.mjs, packages/@react-spectrum/combobox/dist/vars.mjs, 
packages/@react-spectrum/combobox/dist/vars.mjs, packages/@react-spectrum/datepicker/dist/vars.css, 
packages/@react-spectrum/datepicker/dist/vars.cjs, packages/@react-spectrum/datepicker/dist/vars.mjs, 
packages/@react-spectrum/label/dist/vars.css, packages/@react-spectrum/label/dist/vars.cjs, 
packages/@react-spectrum/label/dist/vars.mjs, packages/@react-spectrum/menu/dist/vars.css, 
packages/@react-spectrum/menu/dist/vars.cjs, packages/@react-spectrum/menu/dist/vars.css, 
packages/@react-spectrum/menu/dist/vars.cjs, packages/@react-spectrum/menu/dist/vars.css, 
packages/@react-spectrum/menu/dist/vars.cjs, packages/@react-spectrum/menu/dist/vars.mjs, 
packages/@react-spectrum/menu/dist/vars.mjs, packages/@react-spectrum/menu/dist/vars.mjs, 
packages/@react-spectrum/overlays/dist/vars.css, packages/@react-spectrum/overlays/dist/vars.cjs, 
packages/@react-spectrum/overlays/dist/vars.css, packages/@react-spectrum/overlays/dist/vars.cjs, 
packages/@react-spectrum/overlays/dist/vars.css, packages/@react-spectrum/overlays/dist/vars.cjs, 
packages/@react-spectrum/overlays/dist/vars.mjs, packages/@react-spectrum/overlays/dist/vars.mjs, 
packages/@react-spectrum/overlays/dist/vars.mjs, packages/@react-spectrum/progress/dist/vars.css, 
packages/@react-spectrum/progress/dist/vars.cjs, packages/@react-spectrum/progress/dist/vars.mjs, 
packages/@react-spectrum/radio/dist/vars.css, packages/@react-spectrum/radio/dist/vars.cjs, 
packages/@react-spectrum/radio/dist/vars.mjs

🤔 Expected Behavior?

Contributor can easily follow the CONTRIBUTION.md to install, build and run tests that passes.

Also it would be great to setup dev environments to provide consistent development experiences.

😯 Current Behavior

Occurs errors here and there.

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

N/A

Version

N/A

What browsers are you seeing the problem on?

Other

If other, please specify.

N/A

What operating system are you using?

WSL, MacOS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

[yihuiliao]

Thanks for bringing this up, I definitely think our CONTRIBUTION.md could use some updating since it does seem a bit outdated

[snowystinger]

I pulled down a fresh copy and ran

yarn
yarn jest

with one error.
It succeeds with yarn test, so I think we can just update that.

The yarn build succeeds for me, but the error that you're describing sounds like one we encountered and fixed here #9285 and later with an upgrade of parcel
Can you try again with the latest from main?

There are some expected warnings detailed in the contribution guide, so long as it runs to completion, it succeeds.

[unional]

I was trying that from the latest main. sha: bba710efda672c33c9891ddca8b4d41c4aa3c237ggg

[unional]

btw, it would be great if we can add a clean and nuke script. I do that too most of my repositories:

• clean: remove all cache and build artifacts
• nuke: clean + deleting node_modules, resetting the repository close to the state when it is first cloned.

They help resetting the dev environment to start things over.

[unional]

When I try to remove the built files and node_modules and run yarn && yarn test, it fails with many errors:

yarn test 1160 failed

only a few of them:

● TableView with expandable rows flag on › selection › onAction › should trigger onAction when clicking rows with touch

    TypeError: (0 , $iMOYA$reactarialiveannouncer.announce) is not a function

      at packages/@react-aria/grid/dist/packages/@react-aria/grid/src/useGridSelectionAnnouncement.ts:100:7
      at packages/@react-aria/grid/dist/packages/@react-aria/grid/src/useGridSelectionAnnouncement.ts:118:7
      at packages/@react-aria/utils/dist/packages/@react-aria/utils/src/useEffectEvent.ts:31:12
      at packages/@react-aria/utils/dist/packages/@react-aria/utils/src/useUpdateEffect.ts:34:7
      at Object.react-stack-bottom-frame (node_modules/react-dom/cjs/react-dom-client.development.js:23949:20)
      at runWithFiberInDEV (node_modules/react-dom/cjs/react-dom-client.development.js:1522:13)

 FAIL   component and hooks  packages/dev/codemods/src/s1-to-s2/__tests__/actiongroup.test.ts
  ● Test suite failed to run

    ENOENT: no such file or directory, open '/home/unional/unional/react-spectrum/packages/@react-spectrum/s2/dist/src/index.ts'

      18 |   const packagePath = require.resolve('@react-spectrum/s2');
      19 |   const indexPath = path.join(path.dirname(packagePath), process.env.NODE_ENV === 'test' ? 'src/index.ts' : '../src/index.ts');
    > 20 |   let index = parse(readFileSync(indexPath, 'utf8'), {sourceType: 'module', plugins: ['typescript']});
         |                                 ^
      21 |   traverse(index, {
      22 |     ExportNamedDeclaration(path) {
      23 |       if (path.node.exportKind === 'value') {

      at getComponents (packages/dev/codemods/src/s1-to-s2/src/getComponents.ts:20:33)
      at Object.<anonymous> (packages/dev/codemods/src/s1-to-s2/src/codemods/codemod.ts:12:40)
      at Object.<anonymous> (packages/dev/codemods/src/s1-to-s2/__tests__/actiongroup.test.ts:7:57)

FAIL packages/dev/codemods/src/s1-to-s2/__tests__/actionbutton.test.ts
  ● Test suite failed to run

    ENOENT: no such file or directory, open '/home/unional/unional/react-spectrum/packages/@react-spectrum/s2/dist/src/index.ts'

      18 |   const packagePath = require.resolve('@react-spectrum/s2');
      19 |   const indexPath = path.join(path.dirname(packagePath), process.env.NODE_ENV === 'test' ? 'src/index.ts' : '../src/index.ts');
    > 20 |   let index = parse(readFileSync(indexPath, 'utf8'), {sourceType: 'module', plugins: ['typescript']});
         |                                 ^
      21 |   traverse(index, {
      22 |     ExportNamedDeclaration(path) {
      23 |       if (path.node.exportKind === 'value') {

      at getComponents (packages/dev/codemods/src/s1-to-s2/src/getComponents.ts:20:33)
      at Object.<anonymous> (packages/dev/codemods/src/s1-to-s2/src/codemods/codemod.ts:12:40)
      at Object.<anonymous> (packages/dev/codemods/src/s1-to-s2/__tests__/actionbutton.test.ts:7:57)

Test Suites: 90 failed, 242 passed, 332 total
Tests:       1160 failed, 46 skipped, 5823 passed, 7029 total
Snapshots:   40 passed, 40 total
Time:        257.33 s

Running yarn build doesn't getting it back to fail with less errors.

[snowystinger]

btw, it would be great if we can add a clean and nuke script. I do that too most of my repositories:

We do have that, you can use make clean or make clean_all. We can add those to the yarn script targets as well.

You may still have artifacts around, possibly in one of the caches. Could you pull down a new clone of the repo to a new destination on your machine and try running it again? Otherwise, try running one of the clean's and then follow the steps again.