fix: checkbox in cardview and radio and switch#10012
Conversation
|
Build successful! 🎉 |
| gridTemplateColumns: { | ||
| default: ['max-content', '1fr'], | ||
| isNoVisibleLabel: ['max-content'] | ||
| }, |
There was a problem hiding this comment.
I noticed that the label seems to dictate how wide the CheckBox/RadioGroup are now, is that the desired behavior? To compare, you can try this build from prod (aka commit just before our release) https://reactspectrum.blob.core.windows.net/reactspectrum/009b5a837ce9ad8c3ee91178ba3f56a933ac5df7/storybook-s2/index.html?path=/story/radiogroup--example&args=label:Favorite+sport+fqewkgbkawjeg+bjawbgkjagaw+eg+nawlke+gnawg+knawe+gkanw+elgkawn+lkg
vs from this PR (though this behavior exists on main as well): https://reactspectrum.blob.core.windows.net/reactspectrum/a5167085a1d20567be0f9ce2146cc0ffd4661dca/storybook-s2/index.html?path=/story/radiogroup--example&args=label:Favorite+sport+gawelgn+awe+nglakw+gnlakw+nglawkne+glawneglkawegnlk
There was a problem hiding this comment.
oh nvm I forgot this was intentional from https://github.com/adobe/react-spectrum/pull/9877/changes#diff-43aff8e2be0a942e4e38e2dfe84fe8d8037a5408d5b8a135f0a22042941d8e2fR103. We'll probably need to call this out in the next release since there may be people who were relying on the previous behavior who will now need to constrain the width of their group
There was a problem hiding this comment.
yeah, I was a little unsure about this...
There was a problem hiding this comment.
yeah, I was a little unsure about this...
yihuiliao
left a comment
yihuiliao
left a comment
There was a problem hiding this comment.
mind adding testing instructions or "no testing" label if you think it doesn't need to be manually tested if chromatic coverage is enough
snowystinger
added
the
no testing
4 participants
Closes
Found in chromatic. We can't use implicit columns because we're in a subgrid and subgrids can't create an implicit track.
✅ Pull Request Checklist:
📝 Test Instructions:
Testing should be covered by chromatic
🧢 Your Project: