fix: Menu, Select, and ComboBox inside Tabs#10019
Merged
Merged
Conversation
|
Build successful! 🎉 |
snowystinger
approved these changes
May 6, 2026
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Makes sense, thanks for doing that
LFDanLu
approved these changes
May 6, 2026
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
I could've swore I ran into a issue when trying to make the Menu hideable, but this seems to work well locally for me.
yihuiliao
added
the
no testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9011
Collection triggers should be hideable components so that the parent collection doesn't try to inherit the items from the child collection.