chore: Upgrade vite example project#10025
Merged
Merged
Conversation
|
Build successful! 🎉 |
devongovett
previously approved these changes
May 7, 2026
LFDanLu
previously approved these changes
May 8, 2026
# Conflicts: # examples/s2-vite-project/vite.config.ts
|
Build successful! 🎉 |
LFDanLu
previously approved these changes
May 9, 2026
|
Build successful! 🎉 |
This reverts commit a8a12c9.
snowystinger
commented
May 11, 2026
| // @ts-ignore | ||
| let items = rows | ||
| .slice() | ||
| // @ts-ignore |
Member
Author
There was a problem hiding this comment.
this failed verdaccio, which probably means main as well, but maybe it's just the ts version got an update in this
either way, small and easy to fix
|
Build successful! 🎉 |
reidbarber
approved these changes
May 11, 2026
LFDanLu
approved these changes
May 11, 2026
yihuiliao
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
Test the s2 vite example app
🧢 Your Project: