Add sr-Latn placeholder to datepicker for Serbian Latin locale#10034
Merged
reidbarber merged 1 commit intoMay 11, 2026
Conversation
yihuiliao
previously approved these changes
May 8, 2026
Member
|
Thanks for the PR! Mind signing the CLA and then closing and reopening the pull to run the check again? |
nklaasse
force-pushed
the
fix/sr-latn-datepicker-placeholders
branch
from
111b0ad to
17e4ea2
Compare
nklaasse
force-pushed
the
fix/sr-latn-datepicker-placeholders
branch
from
17e4ea2 to
d3ff7b9
Compare
yihuiliao
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
sr-Latnto the hardcoded placeholder dictionary in@react-stately/datepickerso that users with a Serbian Latin locale (sr-Latn/sr-Latn-RS) see Latin segment placeholders instead of Cyrillic ones.Problem
The
LocalizedStringDictionaryinplaceholders.tshas an entry forsr(Cyrillic:гггг,мм,дд) but no entry forsr-Latn. Because the dictionary falls back fromsr-Latn-RS→sr-Latn→sr, users in a Serbian Latin locale see Cyrillic placeholders (гггг,мм,дд) in date fields instead of the Latin equivalents (gggg,mm,dd).Fix
Add
'sr-Latn': {year: 'gggg', month: 'mm', day: 'dd'}to the dictionary, consistent with the placeholders used by Chrome and Firefox for<input type="date">in that locale.Related issue
Fixes #10033