Skip to content

fix: Make TSDiff not return recent formatting changes as API diffs#10076

Merged
LFDanLu merged 6 commits into
mainfrom
tsdiff_ignore_formatting
May 15, 2026
Merged

fix: Make TSDiff not return recent formatting changes as API diffs#10076
LFDanLu merged 6 commits into
mainfrom
tsdiff_ignore_formatting

Conversation

@LFDanLu
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu commented May 15, 2026

Found when establishing a recent baseline off of #10059 and the number of changes made it impossible to post to Slack. This just normalizes the TSDiff so that it follows the recent formatting changes made by oxlint, won't be necessary once we do another release

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

See https://github.com/LFDanLu/react-spectrum-api-snapshots/blob/main/deltas/2026-05-15.txt and see if that seems about right for changes since 5/4. Can also look at https://github.com/LFDanLu/react-spectrum-api-snapshots/blob/main/diffs/2026-05-15.txt for the full diff

🧢 Your Project:

RSP

@rspbot
Copy link
Copy Markdown

rspbot commented May 15, 2026

@LFDanLu LFDanLu added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 2daaeba May 15, 2026
30 checks passed
@LFDanLu LFDanLu deleted the tsdiff_ignore_formatting branch May 15, 2026 20:10
@yihuiliao yihuiliao added the no testing Does not require manual testing during testing session label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no testing Does not require manual testing during testing session

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants