Skip to content

feat: add MessageFeedback + UserMessage#10086

Merged
yihuiliao merged 5 commits into
setup-ai-components-packagefrom
ai_components_feedback_message
Jun 1, 2026
Merged

feat: add MessageFeedback + UserMessage#10086
yihuiliao merged 5 commits into
setup-ai-components-packagefrom
ai_components_feedback_message

Conversation

@DPandyan
Copy link
Copy Markdown
Collaborator

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@DPandyan DPandyan changed the base branch from main to setup-ai-components-package May 29, 2026 22:30
@DPandyan DPandyan force-pushed the ai_components_feedback_message branch from f943ebe to 369ed5a Compare June 1, 2026 16:09
@github-actions github-actions Bot added v3 and removed S2 labels Jun 1, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Jun 1, 2026

@yihuiliao yihuiliao removed the v3 label Jun 1, 2026
Comment thread packages/@react-spectrum/s2-ai/intl/en-US.json Outdated
Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
@github-actions github-actions Bot added the v3 label Jun 1, 2026
@yihuiliao yihuiliao removed the v3 label Jun 1, 2026
@github-actions github-actions Bot added the v3 label Jun 1, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Jun 1, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Jun 1, 2026

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:DisclosureTitle

 DisclosureTitle {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   children: React.ReactNode
   id?: string
   level?: number = 3
+  styles?: StylesPropWithFont
 }

@react-spectrum/s2-ai

/@react-spectrum/s2-ai:Asset

+Asset {
+
+}

/@react-spectrum/s2-ai:AssetList

+AssetList {
+
+}

/@react-spectrum/s2-ai:BasicHorizontalCard

+BasicHorizontalCard {
+  UNSAFE_className?: UnsafeClassName
+  UNSAFE_style?: CSSProperties
+  children: ReactNode | (CardRenderProps) => ReactNode
+  density?: 'compact' | 'regular' | 'spacious' = 'regular'
+  download?: boolean | string
+  href?: Href
+  hrefLang?: string
+  id?: Key
+  isDisabled?: boolean
+  onAction?: () => void
+  onPress?: (PressEvent) => void
+  onPressChange?: (boolean) => void
+  onPressEnd?: (PressEvent) => void
+  onPressStart?: (PressEvent) => void
+  onPressUp?: (PressEvent) => void
+  ping?: string
+  referrerPolicy?: HTMLAttributeReferrerPolicy
+  rel?: string
+  routerOptions?: RouterOptions
+  size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
+  styles?: StylesProp
+  target?: HTMLAttributeAnchorTarget
+  textValue?: string
+  value?: T
+  variant?: 'primary' | 'secondary' | 'tertiary' | 'quiet' = 'primary'
+}

/@react-spectrum/s2-ai:HorizontalCard

+HorizontalCard {
+  UNSAFE_className?: UnsafeClassName
+  UNSAFE_style?: CSSProperties
+  children: ReactNode | (CardRenderProps) => ReactNode
+  density?: 'compact' | 'regular' | 'spacious' = 'regular'
+  download?: boolean | string
+  href?: Href
+  hrefLang?: string
+  id?: Key
+  isDisabled?: boolean
+  onAction?: () => void
+  onPress?: (PressEvent) => void
+  onPressChange?: (boolean) => void
+  onPressEnd?: (PressEvent) => void
+  onPressStart?: (PressEvent) => void
+  onPressUp?: (PressEvent) => void
+  ping?: string
+  referrerPolicy?: HTMLAttributeReferrerPolicy
+  rel?: string
+  routerOptions?: RouterOptions
+  size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
+  styles?: StylesProp
+  target?: HTMLAttributeAnchorTarget
+  textValue?: string
+  value?: T
+  variant?: 'primary' | 'secondary' | 'tertiary' | 'quiet' = 'primary'
+}

/@react-spectrum/s2-ai:MessageFeedback

+MessageFeedback {
+  UNSAFE_className?: UnsafeClassName
+  UNSAFE_style?: CSSProperties
+  aria-describedby?: string
+  aria-details?: string
+  aria-label?: string
+  aria-labelledby?: string
+  defaultValue?: MessageFeedbackValue
+  id?: string
+  isDisabled?: boolean
+  onChange?: (MessageFeedbackValue) => void
+  onFeedback?: (Exclude<MessageFeedbackValue, null>) => void
+  slot?: string | null
+  styles?: StylesProp
+  thumbDownLabel?: string
+  thumbUpLabel?: string
+  value?: MessageFeedbackValue
+}

/@react-spectrum/s2-ai:UserMessage

+UserMessage {
+  UNSAFE_className?: UnsafeClassName
+  UNSAFE_style?: CSSProperties
+  aria-describedby?: string
+  aria-details?: string
+  aria-label?: string
+  aria-labelledby?: string
+  children: ReactNode
+  id?: string
+  modality?: UserMessageModality = 'fullscreen'
+  slot?: string | null
+  styles?: StylesProp
+}

@rspbot
Copy link
Copy Markdown

rspbot commented Jun 1, 2026

Agent Skills Changes

Modified (22)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/e4cbadb652b01ed4b1ae8c7341ab538421d3c2b9/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/e4cbadb652b01ed4b1ae8c7341ab538421d3c2b9/

@yihuiliao yihuiliao changed the title [WIP] MessageFeedback + UserMessage feat: add MessageFeedback + UserMessage Jun 1, 2026
@yihuiliao yihuiliao marked this pull request as ready for review June 1, 2026 18:49
@yihuiliao yihuiliao merged commit 3176d6c into setup-ai-components-package Jun 1, 2026
31 checks passed
@yihuiliao yihuiliao deleted the ai_components_feedback_message branch June 1, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants