Skip to content

chore: limit labeler false positives#10118

Merged
snowystinger merged 3 commits into
mainfrom
chore-restrict-labeler-false-positives
May 28, 2026
Merged

chore: limit labeler false positives#10118
snowystinger merged 3 commits into
mainfrom
chore-restrict-labeler-false-positives

Conversation

@snowystinger
Copy link
Copy Markdown
Member

Closes

This should only match if we change source files really, maybe css or some others, but if it's just stories or tests, then I'm not sure we need the labeler

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

yihuiliao
yihuiliao previously approved these changes May 27, 2026
Copy link
Copy Markdown
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me!

@snowystinger snowystinger marked this pull request as ready for review May 27, 2026 20:34
@rspbot
Copy link
Copy Markdown

rspbot commented May 28, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented May 28, 2026

Agent Skills Changes

Modified (6)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/79876c11eb8779022ab24e55c3342e9a8a6ac299/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/79876c11eb8779022ab24e55c3342e9a8a6ac299/

@snowystinger snowystinger added small review Easy to review PR no testing Does not require manual testing during testing session labels May 28, 2026
@snowystinger snowystinger added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit cd01412 May 28, 2026
30 checks passed
@snowystinger snowystinger deleted the chore-restrict-labeler-false-positives branch May 28, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no testing Does not require manual testing during testing session small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants