Skip to content

Adjust search padding for large scale #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Adjust search padding for large scale #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c32d0a2
Revert "(RSP-1460) Adjusting search css to match decorated textfield …
devongovett Dec 19, 2019
3dfdcbc
Adjust search padding for large scale
devongovett Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/@adobe/spectrum-css-temp/components/search/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ governing permissions and limitations under the License.

@import '../commons/index.css';

/* override DNA variables to use ones that change in large scale instead of staying static */
:root {
--spectrum-magnifier-text-inbetween-padding: var(--spectrum-global-dimension-size-100);
--spectrum-search-icon-height: var(--spectrum-global-dimension-size-200);
--spectrum-search-icon-width: var(--spectrum-global-dimension-size-200);
--spectrum-search-padding-left: var(--spectrum-global-dimension-size-450);
--spectrum-search-padding-right: var(--spectrum-global-dimension-size-350);
--spectrum-search-quiet-padding-left: var(--spectrum-global-dimension-size-300);
--spectrum-search-quiet-padding-right: var(--spectrum-global-dimension-size-350);
--spectrum-search-icon-top-padding: var(--spectrum-global-dimension-size-85);
}

.spectrum-Search {
Expand All @@ -31,7 +31,7 @@ governing permissions and limitations under the License.
}

&.is-quiet .spectrum-Search-input {
padding-inline-start: calc(var(--spectrum-magnifier-text-inbetween-padding) + var(--spectrum-search-icon-width));
padding-inline-start: var(--spectrum-search-quiet-padding-left);
padding-inline-end: var(--spectrum-search-quiet-padding-right);
}
}
Expand All @@ -47,7 +47,7 @@ governing permissions and limitations under the License.
outline-offset: -2px;

/* Use padding instead of text-indent so long strings don't overlap the icon */
padding-inline-start: calc(calc(calc(var(--spectrum-magnifier-text-inbetween-padding) * 2) + var(--spectrum-search-icon-width)) - 1px);
padding-inline-start: var(--spectrum-search-padding-left);
text-indent: 0;

/* Don't let long strings overlap the close icon */
Expand All @@ -64,10 +64,10 @@ governing permissions and limitations under the License.
.spectrum-Search .spectrum-Search-icon {
display: block;
position: absolute;
height: var(--spectrum-search-icon-height);
width: var(--spectrum-search-icon-width);
inset-inline-start: var(--spectrum-magnifier-text-inbetween-padding);
top: var(--spectrum-search-icon-top-padding);
height: var(--spectrum-global-dimension-size-200);
width: var(--spectrum-global-dimension-size-200);
inset-inline-start: 12px;
top: calc(calc(var(--spectrum-textfield-height) / 2) - calc(var(--spectrum-global-dimension-size-200) / 2));

transition: color var(--spectrum-global-animation-duration-100) ease-in-out;

Expand Down