Skip to content

Make hamburger menu more resistant to specificity bugs#1448

Merged
dannify merged 1 commit intomainfrom
fix-hamburger-menu
Jan 8, 2021
Merged

Make hamburger menu more resistant to specificity bugs#1448
dannify merged 1 commit intomainfrom
fix-hamburger-menu

Conversation

@snowystinger
Copy link
Copy Markdown
Member

Closes
By not trying to apply styles to the button, we don't need to worry about specificity with its own classes. Instead, we wrap it, which allows us to hide it regardless of what the button has for its display.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link
Copy Markdown

Build successful! 🎉

@dannify dannify merged commit c3db4cd into main Jan 8, 2021
@dannify dannify deleted the fix-hamburger-menu branch January 8, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants