Parcel build and publish workflow #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Build successful! View the storybook |
|
Build successful! View the storybook |
|
Build successful! View the storybook |
| git remote rm origin | ||
| git remote add origin "https://github-actions:$GITHUB_TOKEN@github.com/adobe/react-spectrum-v3.git" | ||
| git fetch | ||
| git config --global user.email octobot@github.com |
Member
There was a problem hiding this comment.
i'm assuming this e-mail isn't our own?
snowystinger
approved these changes
Oct 15, 2019
dannify
approved these changes
Oct 15, 2019
|
Build successful! View the storybook |
1 similar comment
|
Build successful! View the storybook |
devongovett
added a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7, but using Parcel to build the packages for release.
NOTE: this relies on a new release of Parcel, so DNM. Related parcel PRs: parcel-bundler/parcel#3583, parcel-bundler/parcel#3613
Building with Parcel allows us to build CSS modules, TypeScript declaration files, ES Module, and CommonJS format JS. This is all configured in the package.json for each package. I've added a small linter for package.json files to ensure this is done correctly.
We will first publish to a temporary artifactory instance, and move to public npm later. Releases will be done by manually bumping versions in package.json, and pushing to the
nextbranch. This will be picked up by CI which will build and release the bumped packages.