Release audit

packages/@react-aria/dnd/src/useAutoScroll.ts

@@ -41,6 +41,7 @@ export function useAutoScroll(ref: RefObject<Element>) {
   return {
     move(x, y) {
       // Most browsers auto scroll natively, but WebKit on macOS does not (iOS does 🤷‍♂️).
+      // https://bugs.webkit.org/show_bug.cgi?id=222636
       if (!isWebKit() || isIOS() || !scrollableRef.current) {
         return;
       }

packages/@react-aria/dnd/stories/Reorderable.tsx

@@ -68,9 +68,9 @@ export function ReorderableGridExample(props) {
       }
 
       if (e.target.dropPosition === 'before') {
-        list.moveBefore(e.target.key, ...items);
+        list.moveBefore(e.target.key, items);
       } else {
-        list.moveAfter(e.target.key, ...items);
+        list.moveAfter(e.target.key, items);
       }
     }
   };

packages/@react-aria/interactions/src/usePress.ts

@@ -301,6 +301,7 @@ export function usePress(props: PressHookProps): PressResult {
         }
 
         // iOS safari fires pointer events from VoiceOver (but only when outside an iframe...)
+        // https://bugs.webkit.org/show_bug.cgi?id=222627
         state.pointerType = isVirtualPointerEvent(e.nativeEvent) ? 'virtual' : e.pointerType;
 
         e.stopPropagation();

packages/@react-aria/overlays/src/ariaHideOutside.ts

@@ -45,6 +45,7 @@ export function ariaHideOutside(targets: HTMLElement[], root = document.body) {
         }
 
         // VoiceOver on iOS has issues hiding elements with role="row". Hide the cells inside instead.
+        // https://bugs.webkit.org/show_bug.cgi?id=222623
         if (node instanceof HTMLElement && node.getAttribute('role') === 'row') {
           return NodeFilter.FILTER_SKIP;
         }

packages/@react-spectrum/tabs/package.json

@@ -31,7 +31,6 @@
     "url": "https://github.com/adobe/react-spectrum"
   },
   "dependencies": {
-    "@adobe/react-spectrum": "^3.8.0",
     "@babel/runtime": "^7.6.2",
     "@react-aria/focus": "^3.2.2",
     "@react-aria/i18n": "^3.3.0",

packages/@react-stately/data/src/useListData.ts

@@ -105,14 +105,14 @@ export interface ListData<T> {
    * @param key - The key of the item to move the items before.
    * @param keys - The keys of the items to move.
    */
-  moveBefore(key: Key, ...keys: Key[]): void,
+  moveBefore(key: Key, keys: Key[]): void,
 
   /**
    * Moves one or more items after a given key.
    * @param key - The key of the item to move the items after.
    * @param keys - The keys of the items to move.
    */
-  moveAfter(key: Key, ...keys: Key[]): void,
+  moveAfter(key: Key, keys: Key[]): void,
 
   /**
    * Updates an item in the list.
@@ -258,7 +258,7 @@ export function createListActions<T>(opts: ListOptions<T>, dispatch: (updater: (
         };
       });
     },
-    moveBefore(key: Key, ...keys: Key[]) {
+    moveBefore(key: Key, keys: Key[]) {
       dispatch(state => {
         let toIndex = state.items.findIndex(item => getKey(item) === key);
         if (toIndex === -1) {
@@ -270,7 +270,7 @@ export function createListActions<T>(opts: ListOptions<T>, dispatch: (updater: (
         return move(state, indices, toIndex);
       });
     },
-    moveAfter(key: Key, ...keys: Key[]) {
+    moveAfter(key: Key, keys: Key[]) {
       dispatch(state => {
         let toIndex = state.items.findIndex(item => getKey(item) === key);
         if (toIndex === -1) {

packages/@react-stately/data/test/useListData.test.js

@@ -306,7 +306,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveBefore('Three', 'One');
+        result.current.moveBefore('Three', ['One']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -326,7 +326,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveBefore('Sam', 'Julia');
+        result.current.moveBefore('Sam', ['Julia']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -343,7 +343,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveBefore('Five', 'Two', 'Three');
+        result.current.moveBefore('Five', ['Two', 'Three']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -363,7 +363,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveBefore('Two', 'Five', 'Six');
+        result.current.moveBefore('Two', ['Five', 'Six']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -383,7 +383,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveBefore('Five', 'One', 'Three');
+        result.current.moveBefore('Five', ['One', 'Three']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -403,7 +403,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveBefore('Two', 'Four', 'Six');
+        result.current.moveBefore('Two', ['Four', 'Six']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -423,7 +423,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveBefore('Three', 'One', 'Five');
+        result.current.moveBefore('Three', ['One', 'Five']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -445,7 +445,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveAfter('Three', 'One');
+        result.current.moveAfter('Three', ['One']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -465,7 +465,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveAfter('Three', 'Five');
+        result.current.moveAfter('Three', ['Five']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -485,7 +485,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveAfter('Five', 'Two', 'Three');
+        result.current.moveAfter('Five', ['Two', 'Three']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -505,7 +505,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveAfter('Two', 'Five', 'Six');
+        result.current.moveAfter('Two', ['Five', 'Six']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -525,7 +525,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveAfter('Five', 'One', 'Three');
+        result.current.moveAfter('Five', ['One', 'Three']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -545,7 +545,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveAfter('Two', 'Four', 'Six');
+        result.current.moveAfter('Two', ['Four', 'Six']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);
@@ -565,7 +565,7 @@ describe('useListData', function () {
       let initialResult = result.current;
 
       act(() => {
-        result.current.moveAfter('Three', 'One', 'Five');
+        result.current.moveAfter('Three', ['One', 'Five']);
       });
 
       expect(result.current.items).not.toBe(initialResult.items);

packages/@react-stately/selection/src/SelectionManager.ts

@@ -70,6 +70,7 @@ export class SelectionManager implements MultipleSelectionManager {
     return this.state.focusedKey;
   }
 
+  /** Whether the first or last child of the focused key should receive focus. */
   get childFocusStrategy(): FocusStrategy {
     return this.state.childFocusStrategy;
   }